Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Gitlab 15.0 #1095

Merged
merged 7 commits into from
May 27, 2022
Merged

Support Gitlab 15.0 #1095

merged 7 commits into from
May 27, 2022

Conversation

timofurrer
Copy link
Member

@timofurrer timofurrer commented May 22, 2022 •
edited
Loading

GitLab 15.0 has been released today 🎉

This change set makes the provider compatible. We've missed a few things:

  • The old K8s cluster integration was removed, therefore I've disabled the tests for GitLab 15.0 and onwards
  • The gitlab_managed_license resource wasn't ready regarding the new approval_status values

@PatrickRice-KSC can you please verify the changes I did in the managed license resource? Did I miss something?

@PatrickRice-KSC @armsnyder @nagyv I've also changed the workflows to test the last three GitLab releases. WDYT? 🏓

@timofurrer timofurrer added this to the v3.15.0 milestone May 22, 2022
@timofurrer timofurrer self-assigned this May 22, 2022
@github-actions github-actions bot added provider resource Adds or modifies a resource tests size/M labels May 22, 2022
@timofurrer timofurrer force-pushed the gitlab-15.0 branch 3 times, most recently from 38f6506 to 4e1decf Compare May 22, 2022 17:22
This was referenced May 22, 2022
Closed
Merged
@timofurrer timofurrer requested a review from nagyv May 22, 2022 17:30
@timofurrer timofurrer linked an issue May 22, 2022 that may be closed by this pull request
Topics API: extend by title property #1043
Closed
1 task
@timofurrer timofurrer linked an issue May 22, 2022 that may be closed by this pull request
GitLab Release support #984
Closed
@github-actions github-actions bot added the data-source Adds or modifies a data-source label May 22, 2022
RicePatrick
RicePatrick requested changes May 22, 2022
View reviewed changes
Copy link
Collaborator

@RicePatrick RicePatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple very small changes!

internal/provider/resource_gitlab_managed_license_test.go Outdated Show resolved Hide resolved
internal/provider/resource_gitlab_topic_test.go Outdated Show resolved Hide resolved
internal/provider/resource_gitlab_topic_test.go Outdated Show resolved Hide resolved
@RicePatrick
Copy link
Collaborator

@timofurrer - I like the workflow changes, nice!

armsnyder
armsnyder requested changes May 22, 2022
View reviewed changes
Copy link
Collaborator

@armsnyder armsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test matrix change. That's a huge help. Mostly my comments are about error handling. The problem is by ignoring the error we could get unexpected test results. You can pass the testing.T argument and call t.Fail if the error is not nil.

internal/provider/resource_gitlab_topic_test.go Outdated Show resolved Hide resolved
internal/provider/data_source_gitlab_repository_file_test.go Outdated Show resolved Hide resolved
internal/provider/resource_gitlab_managed_license.go Outdated Show resolved Hide resolved
internal/provider/resource_gitlab_repository_file_test.go Outdated Show resolved Hide resolved
internal/provider/resource_gitlab_topic_test.go Outdated Show resolved Hide resolved
internal/provider/resource_gitlab_topic_test.go Outdated Show resolved Hide resolved
internal/provider/resource_gitlab_topic_test.go Outdated Show resolved Hide resolved
internal/provider/resource_gitlab_topic_test.go Outdated Show resolved Hide resolved
internal/provider/resource_gitlab_managed_license_test.go Outdated Show resolved Hide resolved
internal/provider/resource_gitlab_topic_test.go Show resolved Hide resolved
@timofurrer timofurrer force-pushed the gitlab-15.0 branch 2 times, most recently from 38d452d to 8d41e3d Compare May 23, 2022 07:28
@timofurrer
Copy link
Member Author

@PatrickRice-KSC @armsnyder I've addressed your feedback. Could you please give it another round? 🏓

RicePatrick
RicePatrick approved these changes May 23, 2022
View reviewed changes
Copy link
Collaborator

@RicePatrick RicePatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my changes. Thanks @timofurrer !

armsnyder
armsnyder approved these changes May 27, 2022
View reviewed changes
Copy link
Collaborator

@armsnyder armsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@timofurrer timofurrer merged commit 36c66a1 into gitlabhq:main May 27, 2022
@github-actions
Copy link

This functionality has been released in v3.15.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RicePatrick RicePatrick RicePatrick approved these changes

@armsnyder armsnyder armsnyder approved these changes

@nagyv nagyv Awaiting requested review from nagyv

Assignees

@timofurrer timofurrer

Labels
data-source Adds or modifies a data-source documentation provider resource Adds or modifies a resource size/L tests workflows
Milestone
v3.15.0
Development

Successfully merging this pull request may close these issues.

Topics API: extend by title property GitLab Release support
3 participants
@timofurrer @RicePatrick @armsnyder