Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling removal from state of microsoft teams integration resource #1113

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Fix handling removal from state of microsoft teams integration resource #1113

merged 1 commit into from
Jun 3, 2022

Conversation

timofurrer
Copy link
Member

This resulted in a nil pointer panic, because when a project wasn't found p would obv. be nil.

Closes: #1110

@timofurrer timofurrer requested a review from RicePatrick June 1, 2022 16:09
@timofurrer timofurrer self-assigned this Jun 1, 2022
@github-actions github-actions bot added provider resource Adds or modifies a resource size/S labels Jun 1, 2022
RicePatrick
RicePatrick approved these changes Jun 3, 2022
View reviewed changes
Copy link
Collaborator

@RicePatrick RicePatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @timofurrer !

@RicePatrick RicePatrick merged commit 0cfe85d into gitlabhq:main Jun 3, 2022
@timofurrer timofurrer added this to the v3.15.1 milestone Jun 8, 2022
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

This functionality has been released in v3.15.1 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RicePatrick RicePatrick RicePatrick approved these changes

Assignees

@timofurrer timofurrer

Labels
provider resource Adds or modifies a resource size/S
Milestone
v3.15.1
Development

Successfully merging this pull request may close these issues.
2 participants
@timofurrer @RicePatrick