Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add current_user data source #1118

Merged
merged 5 commits into from
Jun 11, 2022
Merged

Add current_user data source #1118

merged 5 commits into from
Jun 11, 2022

Conversation

RicePatrick
Copy link
Collaborator

@RicePatrick RicePatrick commented Jun 5, 2022 •
edited
Loading

Description

Closes #1117

Successor of #1109

PR Checklist Acknowledgement

  • I acknowledge that all of the following items are true, where applicable:
    • Resource attributes match 1:1 the names and structure of the API resource in the GitLab API documentation.
    • Examples are updated with:
      • A *.tf file for the resource/s with at least one usage example
      • A *.sh file for the resource/s with an import example (if applicable)
    • New resources have at minimum a basic test with three steps:
      • Create the resource
      • Update the attributes
      • Import the resource
    • No new //lintignore comments were copied from existing code. (Linter rules are meant to be enforced on new code.)

timofurrer
timofurrer requested changes Jun 6, 2022
View reviewed changes
Copy link
Member

@timofurrer timofurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty solid already! I've left a few suggestions :) 🏓

internal/provider/data_source_gitlab_current_user.go Outdated Show resolved Hide resolved
internal/provider/data_source_gitlab_current_user.go Outdated Show resolved Hide resolved
internal/provider/data_source_gitlab_current_user.go Outdated Show resolved Hide resolved
internal/provider/data_source_gitlab_current_user.go Outdated Show resolved Hide resolved
internal/provider/data_source_gitlab_current_user.go Outdated Show resolved Hide resolved
internal/provider/data_source_gitlab_current_user.go Show resolved Hide resolved
internal/provider/data_source_gitlab_current_user_test.go Show resolved Hide resolved
internal/provider/data_source_gitlab_current_user_test.go Outdated Show resolved Hide resolved
internal/provider/graphql_helper.go Outdated Show resolved Hide resolved
internal/provider/graphql_helper.go Outdated Show resolved Hide resolved
@timofurrer timofurrer added this to the v3.16.0 milestone Jun 6, 2022
@RicePatrick
Copy link
Collaborator Author

@timofurrer - Should be good for a re-review here 🏓

@RicePatrick RicePatrick requested a review from timofurrer June 7, 2022 00:51
@github-actions github-actions bot added size/L and removed size/M labels Jun 10, 2022
timofurrer
timofurrer approved these changes Jun 11, 2022
View reviewed changes
Copy link
Member

@timofurrer timofurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@timofurrer timofurrer merged commit 8be3fde into gitlabhq:main Jun 11, 2022
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

This functionality has been released in v3.16.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timofurrer timofurrer timofurrer approved these changes

@armsnyder armsnyder Awaiting requested review from armsnyder

Assignees
No one assigned
Labels
data-source Adds or modifies a data-source documentation provider size/L tests
Milestone
v3.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@RicePatrick @timofurrer