add gitlab_pipeline_schedule resource #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
roidelapluie
requested changes
May 1, 2019
|
|
||
| * `ref` - (Required, string) The branch/tag name will be triggered. | ||
|
|
||
| * `cron` - (Required, string) The cron (e.g. 0 1 * * *). |
There was a problem hiding this comment.
please put the con example as code
|
|
||
| * `description` - (Required, string) The description of the pipeline schedule. | ||
|
|
||
| * `ref` - (Required, string) The branch/tag name will be triggered. |
|
|
||
| # gitlab\_pipeline\_schedule | ||
|
|
||
| This resource allows you to create and manage pipeline schedules |
There was a problem hiding this comment.
- maybe a link to upstream doc?
- missing dot at the end of the sentence
|
tests are failing |
|
0.16.1 is merged |
thojkooi
force-pushed
the
add-gitlab-pipeline-schedule
branch
2 times, most recently
from
613ac20 to
c76edba
Compare
|
I have made the requested changes. Please note the tests are going to be failing until go-gitlab has been updated. The linked PR has been merged, but no release containing it has been made yet. I am happy to make a PR pulling the latest revision for go-gitlab in a separate PR, or would you rather wait for the next release of go-gitlab, @roidelapluie ? |
|
lets wait for release of go-gitlab |
thojkooi
force-pushed
the
add-gitlab-pipeline-schedule
branch
2 times, most recently
from
6ac369b to
78a04db
Compare
|
@roidelapluie the build now succeeds. |
roidelapluie
reviewed
Jun 5, 2019
|
|
||
| pipelineSchedules, response, err := client.PipelineSchedules.ListPipelineSchedules(project, nil) | ||
| if err != nil { | ||
| if response.StatusCode == 404 { |
thojkooi
force-pushed
the
add-gitlab-pipeline-schedule
branch
from
78a04db to
9e711ec
Compare
Signed-off-by: Julien Pivotto <[email protected]>
roidelapluie
force-pushed
the
add-gitlab-pipeline-schedule
branch
from
9e711ec to
64f4139
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new resource
gitlab_pipeline_schedule.This depends on a fix in
go-gitlab: xanzy/go-gitlab#607. Without this, the delete resource will always result in an error and Terraform will fail, even though the resource is deleted within Gitlab.So I guess WIP until the above mentioned PR gets merged and
go-gitlabgets updated in this project.