Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/gitlab_user_sshkey: Ignore leading and trailing whitespaces in key #1175

Merged

Conversation

timofurrer
Copy link
Member

This change set handles ssh keys with leading or trailing whitespaces gracefully - they are simply ignored when diffing and there won't trigger an update.

This is a probably a common source of issue when using it together with tls_private_key.public_key_openssh which appends a newline.

Closes: #1174

@timofurrer timofurrer added this to the v3.17.0 milestone Jul 14, 2022
@timofurrer timofurrer self-assigned this Jul 14, 2022
@github-actions github-actions bot added provider resource Adds or modifies a resource tests size/S labels Jul 14, 2022
@timofurrer timofurrer force-pushed the bugfix/ignore-sshkey-whitespace branch from f4ec726 to df8d4c1 Compare July 14, 2022 06:47
Copy link
Collaborator

@RicePatrick RicePatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@RicePatrick RicePatrick merged commit ac46389 into gitlabhq:main Jul 16, 2022
@github-actions
Copy link

This functionality has been released in v3.17.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
provider resource Adds or modifies a resource size/S tests
Development

Successfully merging this pull request may close these issues.

2 participants