Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_gitlab_group_ldap_link: Update docs #1220

Conversation

Jasper-Ben
Copy link
Contributor

Description

Add a note about the ldap_provider not being the LDAP label value
and add information on how to receive the LDAP server name using a rake
task.

Fixes https://github.com/gitlabhq/terraform-provider-gitlab/issues/605

PR Checklist Acknowledgement

  • I acknowledge that all of the following items are true, where applicable:
    • Resource attributes match 1:1 the names and structure of the API resource in the GitLab API documentation.
    • Examples are updated with:
      • A *.tf file for the resource/s with at least one usage example
      • A *.sh file for the resource/s with an import example (if applicable)
    • New resources have at minimum a basic test with three steps:
      • Create the resource
      • Update the attributes
      • Import the resource
    • No new //lintignore comments were copied from existing code. (Linter rules are meant to be enforced on new code.)

Add a note about the `ldap_provider` not being the LDAP `label` value
and add information on how to receive the LDAP server name using a rake
task.

Fixes https://github.com/gitlabhq/terraform-provider-gitlab/issues/605
Copy link
Member

@timofurrer timofurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @Jasper-Ben for stepping up and creating the PR 🎉

@timofurrer timofurrer added this to the v3.17.0 milestone Aug 19, 2022
@timofurrer timofurrer merged commit f61f8c1 into gitlabhq:main Aug 19, 2022
@github-actions
Copy link

This functionality has been released in v3.17.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

2 participants