-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Enabling pre-existing deploy key on a project #176
Support for Enabling pre-existing deploy key on a project #176
Conversation
* Used to enable a pre-existing key , for which you need to know they gitlab key-id` on a project
I did not realize the will change to pre-create a key just for the test sake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left a few comments
@roidelapluie pushed some changes and added a comment. I would have expected Ci to trigger again but can't see it happening |
@roidelapluie do you have any update on this ? thanks a lot |
If a resource have manually been removed from the UI then error out and let the operator figure what is going on
@roidelapluie all changes done. thanks ! |
@roidelapluie let me know if there is anything more you want me to change on this, i just don't want to miss the next release if is good since i heavily rely on this feature and i am currently running a local build of the provider which is not ideal. thanks! |
thanks |
fixes #64
Allow to enable already existing deploy key on a project by ID