Add support for commit_committer_check and reject_unsigned_commits in push rules

[jrdelarosa8]

Resolves #202, depends on #245

[roidelapluie]

There is not setter? is this computed? can you modify existing tests?

[jrdelarosa8]

Hey @roidelapluie, I can definitely look at the existing tests. Can you clarify what you mean by:

There is not setter? is this computed?

Thanks!

[jrdelarosa8]

When creating a push rule resource via Terraform, we'll receive a 422 response because the push rule(s) already exist (new projects get push rules by default).

This happens via AddProjectPushRule from the client library.

It seems that we can get around this issue by using the PUT/ProjectPushRulesUpdate function and removing the create since this will continue to cause problems/confusion.

Any thoughts?

[jrdelarosa8]

Are any maintainers available to take a look at my most recent question? @roidelapluie

[roidelapluie]

Mmmh that's a tricky one. I will think about it and come back to you.

[jrdelarosa8]

Do you have any additional thoughts?

[armsnyder]

Can you update the test please?

[armsnyder]

I like the idea of changing AddProjectPushRule to EditProjectPushRule, provided that it doesn't cause a problem where EditProjectPushRule also fails due to the push rule not existing, with the same exact race condition.

I also noticed in your change that you are reading these attributes, but you are not setting them in the create or update functions. That's probably what @roidelapluie meant.

[armsnyder]

Closing this since we merged #422 where we added these attributes but moved the config into gitlab_project. Thanks!