Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(project): add the pages_access_level parameter #472

Merged
merged 2 commits into from
Nov 23, 2020

Conversation

jeremad
Copy link
Contributor

@jeremad jeremad commented Oct 29, 2020

This allows to control the visibility of the Pages, see
https://docs.gitlab.com/ee/user/project/pages/pages_access_control.html

Closes: #471

@jeremad jeremad force-pushed the jrm/pages_visibility branch 3 times, most recently from f37045e to 4fad412 Compare October 29, 2020 16:36
@jeremad jeremad changed the title feat(project): add the pages_access_level parameter WIP: feat(project): add the pages_access_level parameter Oct 30, 2020
@jeremad jeremad force-pushed the jrm/pages_visibility branch from 4fad412 to c54e5e3 Compare October 30, 2020 08:39
@jeremad jeremad force-pushed the jrm/pages_visibility branch from c54e5e3 to aa49914 Compare October 30, 2020 10:09
@jeremad jeremad force-pushed the jrm/pages_visibility branch from aa49914 to 489a6bc Compare October 30, 2020 10:45
@jeremad jeremad changed the title WIP: feat(project): add the pages_access_level parameter feat(project): add the pages_access_level parameter Oct 30, 2020
@jeremad
Copy link
Contributor Author

jeremad commented Oct 30, 2020

Ready for review

@tangodev
Copy link

tangodev commented Nov 8, 2020

Hello @jeremad , is there a specific release cycle that this PR has to wait for? I'm asking because all the tests have passed OK, yet the change is not merged in. Just curious, no pressure.

@jeremad
Copy link
Contributor Author

jeremad commented Nov 9, 2020

I am not a maintainer, I am waiting for a review :)

Copy link
Collaborator

@armsnyder armsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Apologies for the delay on this.

@armsnyder armsnyder merged commit db10e24 into gitlabhq:master Nov 23, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Feature request - allow for configuring Pages visibility
3 participants