Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project mirroring #512

Merged
merged 22 commits into from
Jan 14, 2021
Merged

Project mirroring #512

merged 22 commits into from
Jan 14, 2021

Conversation

btyy77c
Copy link
Contributor

@btyy77c btyy77c commented Dec 29, 2020

Adds mirror and mirror_trigger_builds fields to Project

Related to Pull Request: #449

Setup so EE tests can run against changes

@btyy77c btyy77c changed the title Project mirroring #449 Project mirroring Dec 29, 2020
@btyy77c btyy77c mentioned this pull request Dec 29, 2020
@cnuss
Copy link
Contributor

cnuss commented Dec 29, 2020

@nicholasklick @armsnyder here's the new PR that replaces #449 so that EE tests can run, and thanks to @btyy77c for their help.

Looks like we have green checkmarks across the board. Could you take a look and merge if you're happy, also let me know if there are more comments.

cc: @svenstaro @brijshah FYI since you have been tracking progress of this PR

@svenstaro
Copy link
Contributor

Sooo how about we give this the good ol' merge? I really want this feature. :)

@btyy77c btyy77c requested a review from armsnyder January 7, 2021 20:16
@btyy77c
Copy link
Contributor Author

btyy77c commented Jan 7, 2021

@armsnyder Are you available to review this PR? I can try and find someone else if needed.

Thanks!

@cnuss
Copy link
Contributor

cnuss commented Jan 12, 2021

@armsnyder Pinging you again! Are you available to look at this PR?

@btyy77c
Copy link
Contributor Author

btyy77c commented Jan 13, 2021

@cnuss The GitLab team will try and review this tomorrow. 🎉

@btyy77c btyy77c merged commit ef0ddea into master Jan 14, 2021
@btyy77c btyy77c deleted the project_mirroring branch January 14, 2021 21:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants