Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab_project: Check each push rule individually #531

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

armsnyder
Copy link
Collaborator

This should fix an issue where some push rules require GitLab premium.

Fixes #447

This should fix an issue where some push rules require GitLab premium
@armsnyder armsnyder requested a review from sfang97 January 28, 2021 07:38
Copy link
Contributor

@sfang97 sfang97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@armsnyder This LGTM, but since I've been away from Go and TF for a bit, I'm passing this to @btyy77c for an additional review.

Emily, would you mind reviewing this? Thanks 😄

@armsnyder armsnyder requested a review from btyy77c January 30, 2021 08:26
Copy link
Contributor

@btyy77c btyy77c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to update a GitLab starter app, once I removed the fields commit_committer_check and reject_unsigned_commits from the resource.

Looks good to merged!

@armsnyder armsnyder merged commit 88cd2a0 into master Feb 2, 2021
@armsnyder armsnyder deleted the 447-push-rules branch February 2, 2021 07:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Error with push rules for projects and non-premium GitLab version
3 participants