Check for state change on user delete #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roidelapluie
approved these changes
Jan 29, 2021
|
LGTM, one nit |
armsnyder
force-pushed
the
user-delete-wait
branch
from
d129121 to
ce1612d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #533
I analyzed the test debug output and found that the problem was some inconsistency after a user is deleted.
I see
DELETE /api/v4/users/114 HTTP/1.1returnHTTP/1.1 204 No Content, and then later in the test during the destroy check,GET /api/v4/users/114 HTTP/1.1returnsHTTP/1.1 200 OK.This fix adds
WaitForStateto thegitlab_userdelete function.