Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add error handling to resourceGitlabProjectSetToState #649

Merged
merged 1 commit into from
Jul 14, 2021
Merged

chore: add error handling to resourceGitlabProjectSetToState #649

merged 1 commit into from
Jul 14, 2021

Conversation

mattkasa
Copy link
Collaborator

This adds error handling to the resourceGitlabProjectSetToState function which used to call Set repeatedly without checking for errors.

@mattkasa mattkasa requested a review from ash2k July 14, 2021 02:33
ash2k
ash2k approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@ash2k ash2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ash2k ash2k merged commit f980f39 into master Jul 14, 2021
@mattkasa mattkasa deleted the mattkasa-handle-errors-in-project-set-to-state branch July 15, 2021 21:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ash2k ash2k ash2k approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattkasa @ash2k