Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the tfproviderlint linter to the CI workflow. This linter is used by the aws provider and others to catch common mistakes when writing Terraform providers, and will help automate code reviews. Reported issues conveniently show up as code annotations in pull requests.
I littered the code with
// lintignore
comments instead of fixing all of the preexisting issues, since there were so many. The intent is for newly submitted code to adhere to the linter checks, and we can resolve these past issues over time.The full list of checks is documented here. I used the extended ruleset, but with some exceptions: