More examples and better documentation #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
willianpaixao
commented
Jul 15, 2021
willianpaixao
commented
- It includes an example using features from Add most Premium features for gitlab_branch_protection #556
- It includes an example from @sirlatrom in #599
mattkasa
approved these changes
Jul 15, 2021
armsnyder
requested changes
Jul 15, 2021
willianpaixao
force-pushed
the
master
branch
4 times, most recently
from
0b1b2b2 to
79b51b5
Compare
mattkasa
requested changes
Jul 16, 2021
There was a problem hiding this comment.
@willianpaixao I left some suggestions for the other instances where a callout will be used 👍
armsnyder
requested changes
Jul 17, 2021
There was a problem hiding this comment.
Can you go through your callouts and remove **NOTE** from all of them? Try using the doc preview tool and you'll see that it is not needed. Instead, the markdown renderer chooses a title based on the callout level. 😄
willianpaixao
force-pushed
the
master
branch
3 times, most recently
from
4989c4e to
9897e09
Compare
|
Hey @mattkasa, I've applied your suggestions. I can get approval again, please? |
|
Hey @mattkasa @nicholasklick can I get a review here, please? |
|
Hey @roidelapluie can I get a review here, please? |
|
I believe @mattkasa is unavailable this quarter, so I'll merge this now. Hope that's alright. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.