resource/gitlab_project: correctly handle push rules add and edit #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
provider
resource
timofurrer
changed the title
timofurrer
force-pushed
the
bugfix/project-push-rules
branch
2 times, most recently
from
18acd20 to
8b65434
Compare
timofurrer
force-pushed
the
bugfix/project-push-rules
branch
from
8b65434 to
7e3ee19
Compare
armsnyder
requested changes
Feb 4, 2022
timofurrer
force-pushed
the
bugfix/project-push-rules
branch
from
7e3ee19 to
944a927
Compare
|
@armsnyder What do you think about how I solved this? I kinda dislike it and but failed to come up with something better given the constraints of the SDK v2. That exact problem is one of the things addressed in the new framework: https://www.terraform.io/plugin/which-sdk (which we shouldn't switch to just yet, but just saying :D ) |
armsnyder
requested changes
Feb 5, 2022
timofurrer
force-pushed
the
bugfix/project-push-rules
branch
from
944a927 to
5c3f5cd
Compare
armsnyder
approved these changes
Feb 6, 2022
timofurrer
changed the title
This is a possible approach to fix #836. Even though, I am not sure if that is
really that elegant of a solution ...
The root problem here is that the SDK v2 doesn't support to check if an
attribute value was set in config, state or the plan. During creation of
push rules, we don't have a way to distinguish between the default and
if the user has set the default explicitly. This makes the behavior
working for all cases (AFAIK) (incl. changing the instance default push
rules, no automated test possible yet).
This will be possbile in the new terraform provider framework.
timofurrer
force-pushed
the
bugfix/project-push-rules
branch
from
5c3f5cd to
f27db8c
Compare
|
This functionality has been released in v3.10.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible approach to fix https://github.com/gitlabhq/terraform-provider-gitlab/issues/836. Even though, I am not sure if that is
really that elegant of a solution ...
The root problem here is that the SDK v2 doesn't support to check if an
attribute value was set in config, state or the plan. During creation of
push rules, we don't have a way to distinguish between the default and
if the user has set the default explicitly. This makes the behavior
working for all cases (AFAIK) (incl. changing the instance default push
rules, no automated test possible yet).
This will be possbile in the new terraform provider framework