Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datasource/gitlab_projects: Allow to get archived and unarchived repositories. Closes #452 #855

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

timofurrer
Copy link
Member

This change makes use of the deprecated d.GetOkExists() function to
check if a boolean attribute has been set by the user or not.
AFAIK, it's the only way to achieve that in the SDK v2. It doesn't seem
to go anywhere without a proper replacement.

See:

Closes #452

@github-actions github-actions bot added data-source Adds or modifies a data-source provider tests size/M labels Feb 8, 2022
…sitories. Closes #452

This change makes use of the deprecated `d.GetOkExists()` function to
check if a boolean attribute has been set by the user or not.
AFAIK, it's the only way to achieve that in the SDK v2. It doesn't seem
to go anywhere without a proper replacement.

See:

* hashicorp/terraform-plugin-sdk#817
* hashicorp/terraform-plugin-sdk#350 (comment)

Closes #452
@timofurrer timofurrer requested a review from armsnyder February 8, 2022 21:09
@timofurrer timofurrer self-assigned this Feb 8, 2022
@timofurrer timofurrer added this to the v3.10.0 milestone Feb 8, 2022
Copy link
Collaborator

@armsnyder armsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I agree this is our best move for now. Thanks for the comments.

@timofurrer timofurrer merged commit 295685c into gitlabhq:main Feb 9, 2022
@github-actions
Copy link

This functionality has been released in v3.10.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
data-source Adds or modifies a data-source provider size/M tests
Development

Successfully merging this pull request may close these issues.

2 participants