Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/gitlab_project: fix backwards-compatibility with 14.1 regarding the squash_option. Closes #770 #867

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

timofurrer
Copy link
Member


I gotta admit that I'm not support happy with the implementation,
nor the approach in general.

However, I think we agree that it's best to not break backwards
compatiblity as first priority.

In any case, we have #550 to discuss that :)

Closes #770
Closes #776

…ing the `squash_option`. Closes #770

I gotta admit that I'm not support happy with the implementation,
nor the approach in general.

However, I think we agree that it's best to not break backwards
compatiblity as first priority.

In any case, we have #550 to discuss that :)

Closes #770
Closes #776
@timofurrer timofurrer requested a review from armsnyder February 11, 2022 17:59
@timofurrer timofurrer self-assigned this Feb 11, 2022
@timofurrer timofurrer added the compatibility For compatibility issues label Feb 11, 2022
Copy link
Collaborator

@armsnyder armsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, given that the schema value has a default. This seems like a highly requested bug fix so let's merge.

@armsnyder armsnyder added this to the v3.10.0 milestone Feb 14, 2022
@timofurrer timofurrer merged commit 0838ca3 into gitlabhq:main Feb 14, 2022
@github-actions
Copy link

This functionality has been released in v3.10.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compatibility For compatibility issues documentation provider resource Adds or modifies a resource size/S tests
Development

Successfully merging this pull request may close these issues.

2 participants