Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source datasource/gitlab_instance_deploy_keys #870

Merged
merged 1 commit into from
Mar 14, 2022
Merged

New Data Source datasource/gitlab_instance_deploy_keys #870

merged 1 commit into from
Mar 14, 2022

Conversation

timofurrer
Copy link
Member

@timofurrer timofurrer commented Feb 13, 2022 •
edited
Loading

This PR is work in progress and requires the release go-gitlab first, including this change set:

Open points:

  • update go-gitlab once released
  • write examples
  • write documentation
  • finish implementing tests

Closes #373

@timofurrer timofurrer added the blocked We are currently blocked to implement this label Feb 13, 2022
@timofurrer timofurrer self-assigned this Feb 13, 2022
@github-actions github-actions bot added data-source Adds or modifies a data-source provider tests size/L labels Feb 13, 2022
@timofurrer timofurrer marked this pull request as draft February 13, 2022 17:00
@timofurrer timofurrer force-pushed the feature/instance-deploy-keys-373 branch 2 times, most recently from 859a94e to ef8f306 Compare February 13, 2022 17:22
@timofurrer timofurrer force-pushed the feature/instance-deploy-keys-373 branch from ef8f306 to 771c257 Compare March 9, 2022 16:09
@timofurrer timofurrer added the go-gitlab Is related to go-gitlab. Maybe be combined with other labels, like `blocked`. label Mar 9, 2022
@timofurrer timofurrer force-pushed the feature/instance-deploy-keys-373 branch from 771c257 to 29c61c9 Compare March 9, 2022 17:07
@timofurrer timofurrer removed blocked We are currently blocked to implement this go-gitlab Is related to go-gitlab. Maybe be combined with other labels, like `blocked`. labels Mar 9, 2022
@timofurrer timofurrer requested a review from armsnyder March 9, 2022 17:07
@github-actions github-actions bot added dependencies resource Adds or modifies a resource labels Mar 9, 2022
@timofurrer timofurrer force-pushed the feature/instance-deploy-keys-373 branch from 29c61c9 to 2b55103 Compare March 9, 2022 17:11
@timofurrer timofurrer added this to the v3.13.0 milestone Mar 9, 2022
@timofurrer timofurrer marked this pull request as ready for review March 9, 2022 17:11
@timofurrer timofurrer changed the title WIP: datasource/gitlab_instance_deploy_key: support as new resource. Closes #373 New Data Source datasource/gitlab_instance_deploy_key Mar 9, 2022
@timofurrer timofurrer changed the title New Data Source datasource/gitlab_instance_deploy_key New Data Source datasource/gitlab_instance_deploy_keys Mar 11, 2022
armsnyder
armsnyder previously approved these changes Mar 14, 2022
View reviewed changes
Copy link
Collaborator

@armsnyder armsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, my comment is not blocking merge

internal/provider/data_source_gitlab_instance_deploy_keys.go Outdated Show resolved Hide resolved
@timofurrer timofurrer force-pushed the feature/instance-deploy-keys-373 branch from 2b55103 to de324e7 Compare March 14, 2022 08:46
@timofurrer timofurrer merged commit f854d3e into gitlabhq:main Mar 14, 2022
@github-actions
Copy link

This functionality has been released in v3.13.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armsnyder armsnyder armsnyder approved these changes

Assignees

@timofurrer timofurrer

Labels
data-source Adds or modifies a data-source dependencies documentation provider resource Adds or modifies a resource size/L tests
Milestone
v3.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@timofurrer @armsnyder