Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitlab_project] re-compute project attributes if path or namespace changed #875

Merged
merged 1 commit into from
Feb 20, 2022

Conversation

QuingKhaos
Copy link
Contributor

@QuingKhaos QuingKhaos commented Feb 17, 2022

Description

All project attributes which are affected by a namespace or path change are re-computed if changed and dependent resources on those attributes will be updated in the same run.

Closes: #874

PR Checklist

  • (not applicable) Resource attributes match 1:1 the names and structure of the API resource in the GitLab API documentation.
  • (not applicable) Examples are updated with:
    • A *.tf file for the resource/s with at least one usage example
    • A *.sh file for the resource/s with an import example (if applicable)
  • (not applicable) New resources have at minimum a basic test with three steps:
    • Create the resource
    • Update the attributes
    • Import the resource
  • Fix is covered via tests
  • No new //lintignore comments that came from copied code. Linter rules are meant to be enforced on new code.

@github-actions github-actions bot added provider resource Adds or modifies a resource tests size/M labels Feb 17, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @QuingKhaos 👋

It looks like this is your first submission to the Terraform GitLab Provider! If you haven’t already done so, please make sure you have checked out our CONTRIBUTING.md guide to make sure your contribution has all the necessary elements in place for a successful approval.

Thanks again, and welcome to the community! 😃

@QuingKhaos QuingKhaos changed the title fix: re-compute project attributes if path or namespace changed fix(gitlab_project): re-compute project attributes if path or namespace changed Feb 17, 2022
@QuingKhaos QuingKhaos changed the title fix(gitlab_project): re-compute project attributes if path or namespace changed [gitlab_project] re-compute project attributes if path or namespace changed Feb 17, 2022
Copy link
Member

@timofurrer timofurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@timofurrer timofurrer merged commit 2b3e9c2 into gitlabhq:main Feb 20, 2022
@timofurrer timofurrer added this to the v3.10.0 milestone Feb 20, 2022
@QuingKhaos QuingKhaos deleted the fix/project-recompute-path branch February 20, 2022 16:59
@github-actions
Copy link

This functionality has been released in v3.10.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
provider resource Adds or modifies a resource size/M tests
Development

Successfully merging this pull request may close these issues.

2 participants