resource/gitlab_branch_protection: fix issue claiming that no valid access level can be found. Closes #890 #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
provider
resource
…ccess level can be found. Closes #890 I don't really understand yet what happens here. However, that behavior changed from v3.9.1 to v3.10.0. Thus, I'm simply reverting it back. We've had a brief exchange about this already when the "broken" code was merged here: gitlabhq#881 (comment) Obviously, we made the wrong call in that this situation doesn't happen ... well, it happened. Looking at the `gitlab_branch_protection` resource I find that it's kinda unclear what's going on, also looking at the upstream API docs doesn't shed any lights on this as the documentation is quite sparse. Some of this was lately raised by @beekeep in https://github.com/gitlabhq/terraform-provider-gitlab/issues/878#issuecomment-1048902570 , that is that some fields are arguments in the provider, but optional in the upstream API. Also the implemented logic to retrieve the set `push_access_level` and `merge_access_level` can only be guessed when trying to understand how those values come to be from a `POST` to a `GET` request of the [Protected Branches API](https://docs.gitlab.com/ee/api/protected_branches.html). Closes #890
timofurrer
force-pushed
the
bugfix/issue-890
branch
from
89cd584 to
a57f5ee
Compare
armsnyder
approved these changes
Feb 24, 2022
nagyv
reviewed
Feb 24, 2022
| @@ -1,3 +1,9 @@ | |||
| ## 3.10.0 (2022-02-24) | |||
There was a problem hiding this comment.
Suggested change
| ## 3.10.0 (2022-02-24) | |
| ## 3.10.1 (2022-02-24) |
|
This functionality has been released in v3.10.1 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't really understand yet what happens here. However, that behavior
changed from v3.9.1 to v3.10.0. Thus, I'm simply reverting it back.
We've had a brief exchange about this already when the "broken" code was
merged here: #881 (comment)
Obviously, we made the wrong call in that this situation doesn't
happen ... well, it happened.
Looking at the
gitlab_branch_protectionresource I find that it'skinda unclear what's going on, also looking at the upstream API docs
doesn't shed any lights on this as the documentation is quite sparse.
Some of this was lately raised by @beekeep in
https://github.com/gitlabhq/terraform-provider-gitlab/issues/878#issuecomment-1048902570
, that is that some fields are arguments in the provider, but optional
in the upstream API. Also the implemented logic to retrieve the set
push_access_levelandmerge_access_levelcan only be guessed whentrying to understand how those values come to be from a
POSTto aGETrequest of the Protected BranchesAPI.
Closes #890
Description
PR Checklist Acknowledgement
//lintignorecomments were copied from existing code. (Linter rules are meant to be enforced on new code.)