Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project: Add merge_pipelines_enabled and merge_trains_enabled. Closes #623 #900

Merged
merged 3 commits into from
Feb 28, 2022

Conversation

jtymes
Copy link
Collaborator

@jtymes jtymes commented Feb 24, 2022

Description

Add merge_pipelines_enabled and merge_trains_enabled. This allows for managing Merged Results Pipelines and Merge Trains. Closes #623

PR Checklist Acknowledgement

  • I acknowledge that all of the following items are true, where applicable:
    • Resource attributes match 1:1 the names and structure of the API resource in the GitLab API documentation.
    • Examples are updated with:
      • A *.tf file for the resource/s with at least one usage example
      • A *.sh file for the resource/s with an import example (if applicable)
    • New resources have at minimum a basic test with three steps:
      • Create the resource
      • Update the attributes
      • Import the resource
    • No new //lintignore comments were copied from existing code. (Linter rules are meant to be enforced on new code.)

…oses #623

This allows for managing Merged Results Pipelines and Merge Trains.
@github-actions github-actions bot added data-source Adds or modifies a data-source documentation provider resource Adds or modifies a resource tests size/M labels Feb 24, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @jtymes 👋

It looks like this is your first submission to the Terraform GitLab Provider! If you haven’t already done so, please make sure you have checked out our CONTRIBUTING.md guide to make sure your contribution has all the necessary elements in place for a successful approval.

Thanks again, and welcome to the community! 😃

Copy link
Member

@timofurrer timofurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, a nitpick, but in general LGTM 🎉

docs/data-sources/project.md Outdated Show resolved Hide resolved
docs/resources/project.md Show resolved Hide resolved
timofurrer
timofurrer previously approved these changes Feb 24, 2022
@timofurrer timofurrer added this to the v3.11.0 milestone Feb 24, 2022
@timofurrer
Copy link
Member

@jtymes there are some test failures against a CE instance. The reason for this is that the fields are EE only ...

@jtymes
Copy link
Collaborator Author

jtymes commented Feb 24, 2022

@timofurrer Whoops, forgot to restart acceptance in CE. Should I just remove those fields from TestAccGitlabProject_basicthen? Still trying to figure out the structure of all the tests 🙂 .

@timofurrer
Copy link
Member

@jtymes Yes, in this case that's okay, since you have the additional tests and is basically what is already being done for other flags like merge_requests_templates, or mirror_trigger_builds, ... :)

@timofurrer timofurrer merged commit b4bf779 into gitlabhq:main Feb 28, 2022
@jtymes jtymes deleted the feature/merge-results-pipelines-623 branch February 28, 2022 12:04
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This functionality has been released in v3.11.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
data-source Adds or modifies a data-source documentation provider resource Adds or modifies a resource size/M tests
Development

Successfully merging this pull request may close these issues.

2 participants