-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
project: Add merge_pipelines_enabled
and merge_trains_enabled
. Closes #623
#900
project: Add merge_pipelines_enabled
and merge_trains_enabled
. Closes #623
#900
Conversation
…oses #623
This allows for managing Merged Results Pipelines and Merge Trains.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @jtymes 👋
It looks like this is your first submission to the Terraform GitLab Provider! If you haven’t already done so, please make sure you have checked out our CONTRIBUTING.md guide to make sure your contribution has all the necessary elements in place for a successful approval.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, a nitpick, but in general LGTM 🎉
@jtymes there are some test failures against a CE instance. The reason for this is that the fields are EE only ... |
@timofurrer Whoops, forgot to restart acceptance in CE. Should I just remove those fields from |
@jtymes Yes, in this case that's okay, since you have the additional tests and is basically what is already being done for other flags like |
This functionality has been released in v3.11.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you! |
Description
Add
merge_pipelines_enabled
andmerge_trains_enabled
. This allows for managing Merged Results Pipelines and Merge Trains. Closes #623PR Checklist Acknowledgement
//lintignore
comments were copied from existing code. (Linter rules are meant to be enforced on new code.)