-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/gitlab_user_sshkey: add new resource. Closes #40, 716 #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #40
github-actions
bot
added
dependencies
documentation
provider
resource
Adds or modifies a resource
tests
size/L
labels
Feb 26, 2022
eonpatapon
reviewed
Feb 26, 2022
Thanks for moving this forward! |
armsnyder
requested changes
Feb 28, 2022
Forget to push? 🤔 |
oups, check again 😇 |
… and general functionality of the resource
armsnyder
approved these changes
Feb 28, 2022
This functionality has been released in v3.11.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the liberty to finish #716 and therefore made some significant changes to it to make it work properly.
Thanks @eonpatapon for getting this started 🎉
Closes: #40
Closes #716
I'll followup up next with on this PR with other PRs for global ssh key resources and MR in GitLab itself to improve the API.