-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add gitlab_repository_file data source #939
feat: Add gitlab_repository_file data source #939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give this approach a shot:
For that to work you may also add the additional read-only fields to the gitlab_repository_file
resource as Computed
.
If you don't want I can later or tomorrow give it a shot, no worries.
Also, the examples are missing ;)
Well, I posted this because I was not sure why does this error out and wanted to ask for advice https://github.com/gitlabhq/terraform-provider-gitlab/runs/5461795214?check_suite_focus=true#step:6:34 But the approach with the schema seems interesting. |
@petrmvala It's unrelated, but probably related to #820 ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think we leave the things with datasourceSchemaFromResourceSchema()
for now and go with the proposed approach.
This data source is part of Gitlab API.
Closes: #927
@petrmvala I took the liberty and followed up on this. I'll merge once the checks passed! Thank you very much for the contribution! 🎉 |
This functionality has been released in v3.13.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you! |
This data source is part of Gitlab API.
Closes: #927
Description
PR Checklist Acknowledgement
//lintignore
comments were copied from existing code. (Linter rules are meant to be enforced on new code.)