resource/gitlab_repository_file: Mitigate parallelism limitation #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timofurrer
force-pushed
the
feature/repository-file-parallelism-940
branch
2 times, most recently
from
66420da to
35a966d
Compare
github-actions
bot
added
documentation
provider
resource
timofurrer
changed the title
jtymes
suggested changes
Mar 17, 2022
timofurrer
force-pushed
the
feature/repository-file-parallelism-940
branch
from
8579b91 to
2ae4582
Compare
jtymes
previously approved these changes
Mar 17, 2022
armsnyder
requested changes
Mar 19, 2022
armsnyder
reviewed
Mar 19, 2022
timofurrer
force-pushed
the
feature/repository-file-parallelism-940
branch
from
2ae4582 to
fa82d67
Compare
timofurrer
force-pushed
the
feature/repository-file-parallelism-940
branch
3 times, most recently
from
e309bf4 to
5ecb57c
Compare
github-actions
bot
added
the
merge-conflict
|
This pull request has merge conflicts. Please rebase your branch onto |
timofurrer
force-pushed
the
feature/repository-file-parallelism-940
branch
from
5ecb57c to
e189068
Compare
github-actions
bot
removed
the
merge-conflict
|
Conflicts are resolved. Thank you! 😀 |
armsnyder
approved these changes
Mar 22, 2022
|
This functionality has been released in v3.13.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set implements the following two measures to mitigate / remove the parallelism issues we were having as described in #940:
gitlab_repository_fileresource to make an API call (no matter to which project or file)The first mitigates that resources within an apply / destroy are queued and the second mitigates the case when something else outside of terraform changes the repository state. Both combined are good mitigations for the issue at hand.
The drawback of this change is that it'll slow down certain terraform configurations - necessarily and unnecessarily in cases were a files in different repositories / projects are changed, but still queued. I think that's a limitation I'm willing to take for the benefits it provides.
Closes #940