Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/gitlab_topic: support proper deletion of topics #967

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

timofurrer
Copy link
Member

This is blocked by the GitLab 14.9 release :)

Closes: #966

@timofurrer timofurrer added the blocked We are currently blocked to implement this label Mar 19, 2022
@timofurrer timofurrer added this to the v3.13.0 milestone Mar 19, 2022
@timofurrer timofurrer self-assigned this Mar 19, 2022
@timofurrer timofurrer marked this pull request as draft March 19, 2022 13:16
@github-actions github-actions bot added the merge-conflict PR cannot be merged due to a merge conflict label Mar 21, 2022
@github-actions
Copy link

This pull request has merge conflicts. Please rebase your branch onto main.

@timofurrer timofurrer force-pushed the feature/delete-topic branch from 8f9c77a to 3984d1f Compare March 22, 2022 14:27
@github-actions
Copy link

Conflicts are resolved. Thank you! 😀

@github-actions github-actions bot removed the merge-conflict PR cannot be merged due to a merge conflict label Mar 22, 2022
@timofurrer timofurrer removed the blocked We are currently blocked to implement this label Mar 22, 2022
jtymes
jtymes previously approved these changes Mar 22, 2022
internal/provider/resource_gitlab_topic.go Outdated Show resolved Hide resolved
jtymes
jtymes previously approved these changes Mar 22, 2022
@timofurrer timofurrer force-pushed the feature/delete-topic branch from 0bf4d20 to 47298a7 Compare March 22, 2022 22:24
@timofurrer timofurrer marked this pull request as ready for review March 23, 2022 11:01
@beekeep beekeep self-requested a review March 25, 2022 20:30
Copy link
Collaborator

@beekeep beekeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

Copy link
Collaborator

@nagyv nagyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after @beekeep and @jtymes

@timofurrer timofurrer merged commit 78f3946 into gitlabhq:main Mar 28, 2022
@github-actions
Copy link

This functionality has been released in v3.13.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

4 participants