-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "owner" as valid access level for the group_access_token resource #999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @defreng 👋
It looks like this is your first submission to the Terraform GitLab Provider! If you haven’t already done so, please make sure you have checked out our CONTRIBUTING.md guide to make sure your contribution has all the necessary elements in place for a successful approval.
Thanks again, and welcome to the community! 😃
Aleeexx 👋 Can you prove that it works by adding a new test step? 💃 |
Timo! 🙌 Would you have any objections against just changing the existing tests to use the "owner" access level instead of maintainer? |
Hmmm, I think eventually it would be nice to check all the accepted access levels (maybe something for another PR though). Thus, let's add a separate test step :) |
@defreng Can you please rebase so that the tests are passing again? |
done 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Description
The Gitlab API documentation does not mention the possibility to select access level 50 (=owner), but this option is both working (I verified it manually with an API call) and also exposed in the Gitlab UI:
PR Checklist Acknowledgement
//lintignore
comments were copied from existing code. (Linter rules are meant to be enforced on new code.)