Switch to plaintext fingerprint #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed repo ("machine") fingerprint to plaintext full_name of repo
* This also allowed me to remove a lot of the code that was specific to
the schedule event.
* It looks like repository.html_url and repository.full_name are already
included in the schedule event:
https://github.com/dhimmel/dump-actions-context/actions/runs/3191708047/jobs/5208342350
(but we should test)
|
@zricethezav Can you review? But do not merge yet because:
|
|
@weineran changes look good to me. I'm glad we can remove the "schedule" event backfill code. Let me know if you want me to build Gonna be busy for a few hours this morning, but will have some time this afternoon |
added 2 commits
October 8, 2022 06:03
* Reinstalled node modules with correct node version to hopefully fix package-lock.json
Let's plan to merge this on Monday during our meeting. We should clear out the machines list right before we merge, then we should merge and release, then clear out the machines list again. Then monitor for a couple days to see if anyone is pinned to a minor version. |
|
If you get some time, go for it! Otherwise, I will!
…On Fri, Oct 7, 2022, 6:42 AM Zachary Rice ***@***.***> wrote:
@weineran <https://github.com/weineran> changes look good to me. I'm glad
we can remove the "schedule" event backfill code. Let me know if you want
me to build dist then rebase to see if that fixes the package-lock.json
diff.
Gonna be busy for a few hours this morning, but will have some time this
afternoon
—
Reply to this email directly, view it on GitHub
<#98 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNAEIPBTLV5AEUXRDZ2KU3WCASF7ANCNFSM6AAAAAAQ7G6DHI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/dhimmel/dump-actions-context/actions/runs/3191708047/jobs/5208342350 (but we should test)