Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Highlighting & Emmet Support don't work #2444

Closed
bravoalpha79 opened this issue Dec 7, 2020 · 25 comments · Fixed by #2457
Closed

Code Highlighting & Emmet Support don't work #2444

bravoalpha79 opened this issue Dec 7, 2020 · 25 comments · Fixed by #2457
Assignees
Labels
type: bug Something isn't working

Comments

@bravoalpha79
Copy link

Describe the bug

Since the outage on Friday 04/12/2020, multiple students have reported various issues on their workspaces:

  • code highlighting not working (all code displayed as plain white text),
  • Emmet code shortcuts not available, or available only partially (e.g. working in HTML but not in CSS),
  • some workspaces not accessible at all since Friday (stuck in opening state indefinitely, without any feedback).

Some issues seem to be workspace-related (the student that couldn't open his workspace was able to create a new one from the repo and that one worked), but some seem to be user-wide (code highlighting for the student worked on neither his workspace nor on mine shared, even though it worked normally at my end).

For the Emmet shortcuts, it seems that manual installing of the CSS Language Features and HTML Language Features extensions helped restore the functionality.

Steps to reproduce

Workspace that wouldn't open at all: https://c4812cfa-7975-45bf-9b06-62367ca91af0.ws-eu03.gitpod.io/#/workspace/V_Getable

Expected behavior

Workspaces should open without errors.
Code highlighting should work.
Emmet support should work.

@NielMc
Copy link

NielMc commented Dec 7, 2020

I am getting the following error if I try and open a github repo as a gitpod workspace.
failed to create containerd task: OCI runtime create failed: container_linux.go:349: starting container process caused "exec: "/theia/supervisor": stat /theia/supervisor: no such file or directory": unknown; last backup failed: workspace content was never ready. Please contact support if you need the workspace data.

@corneliusludmann corneliusludmann added type: bug Something isn't working critical labels Dec 7, 2020
@0x7466
Copy link

0x7466 commented Dec 7, 2020

We have the same problem! We can't work at all.

@svenefftinge
Copy link
Member

We are working on it.

@akosyakov
Copy link
Member

@bravoalpha79 Could you share workspace ID for which code highlighting won't work? And a snapshot if possible thank you. You can email me anton at gitpod.io if it is confidential.

@svenefftinge
Copy link
Member

I am getting the following error if I try and open a github repo as a gitpod workspace.
failed to create containerd task: OCI runtime create failed: container_linux.go:349: starting container process caused "exec: "/theia/supervisor": stat /theia/supervisor: no such file or directory": unknown; last backup failed: workspace content was never ready. Please contact support if you need the workspace data.

This has been solved and is a duplicate of #2445
Sorry for blocking you.

@svenefftinge svenefftinge changed the title Multiple issues on workspaces Code Highlighting & Emmet Support don't work Dec 7, 2020
@svenefftinge
Copy link
Member

I have changed the title to make this issue focus on the problem regarding syntax coloring and emmet (probably caused by the same issue). For any other problems, please file dedicated issues. Thank you!

@bravoalpha79
Copy link
Author

bravoalpha79 commented Dec 7, 2020 via email

@akosyakov
Copy link
Member

akosyakov commented Dec 8, 2020

@bravoalpha79 Could you check please the devtools network tab for any broken requests for such students? i.e.:

  • start a workspace
  • open devtools -> network tab
  • reload the page and watch out for any requests which are failing, particularly to wasm files
    • chrome will highlight them with red and they will have status 4xx or 5xx, e.g 404 or 500

thank you!

@bravoalpha79
Copy link
Author

bravoalpha79 commented Dec 8, 2020 via email

@svenefftinge
Copy link
Member

Hi Igor, thanks but the images don't show up on GitHub. unfortunately.

@bravoalpha79
Copy link
Author

bravoalpha79 commented Dec 8, 2020 via email

@svenefftinge
Copy link
Member

Go to this page and drag & drop the image into the text area would work.

@bravoalpha79
Copy link
Author

image (15)
image (14)
image (13)
image (12)
image (11)

@bravoalpha79
Copy link
Author

bravoalpha79 commented Dec 8, 2020 via email

@akosyakov
Copy link
Member

the fix is already almost there: #2457 😉

@akosyakov
Copy link
Member

We merged the tentative fix and will deploy it at the end of this week. In the meantime it would be helpful if you can verify it by using this env: http://ak-onigasm-from-blobserve.staging.gitpod-dev.com/workspaces/

@bravoalpha79 Could you ask students experiencing issues to try it there? If it fails it would be good if they can capture details (request/response headers) of failed requests from devtools network, see: https://developers.google.com/web/tools/chrome-devtools/network#details

@bravoalpha79
Copy link
Author

bravoalpha79 commented Dec 9, 2020 via email

@bravoalpha79
Copy link
Author

image
image
image

@akosyakov
Copy link
Member

Oh, it makes sense, in upstream it was changed how html/css are consumed: eclipse-theia/theia#7972 we should add VS Code extensions now explicitly.

But I was concerned with syntax highlighting in general, as far as I understood for some students it did not work at all. Does it work with the staging env?

@akosyakov
Copy link
Member

PR to add missing language smartness for html/css: #2483

@bravoalpha79
Copy link
Author

@akosyakov
As far as I can tell, everything seems fine with code highlighting:
image
image
image

However I never experienced any issues with the highlighting in any of my workspaces, so I can't verify that anything has changed in that regard.

@akosyakov
Copy link
Member

fixes were deployed, please open new issues if something still does not work

@bravoalpha79
Copy link
Author

bravoalpha79 commented Dec 11, 2020

Fix not working. CSS Emmet now apparently works, but HTML Emmet is completely absent.
Moreover, the workspace crashes/disconnects after <30 sec:
image

Two examples of impacted workspaces:
https://f965e451-dbbc-4dc7-8603-a9a2c98b7da5.ws-eu03.gitpod.io/#/workspace/newtestrepo
https://f1abf907-ec9c-42a9-aee4-c500348cbc4a.ws-eu03.gitpod.io/#/workspace/newgitpod

@akosyakov akosyakov reopened this Dec 11, 2020
@bravoalpha79
Copy link
Author

I am now unable to properly open any workspace. When I do and add some code and attempt to save it, the workspace disconnects.
Even after reconnecting, any attempt to add new code and save it results in a disconnection.
This applies to both workspaces with a Docker template and without it.
Latest example: https://bff21d7d-1fad-474a-8c9c-879b8fa255d6.ws-eu03.gitpod.io/#/workspace/notemplate

image

@svenefftinge
Copy link
Member

This should have been fixed by now. There has been a couple of other issue reported here as well. Please open new issues for anything that is still prevailing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants