-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Highlighting & Emmet Support don't work #2444
Comments
I am getting the following error if I try and open a github repo as a gitpod workspace. |
We have the same problem! We can't work at all. |
We are working on it. |
@bravoalpha79 Could you share workspace ID for which code highlighting won't work? And a snapshot if possible thank you. You can email me anton at gitpod.io if it is confidential. |
This has been solved and is a duplicate of #2445 |
I have changed the title to make this issue focus on the problem regarding syntax coloring and emmet (probably caused by the same issue). For any other problems, please file dedicated issues. Thank you! |
Hi Anton,
I can indeed share a snapshot if needed, but that won't do you any good as
the same workspace looked perfectly normally at my end.
Example - my workspace at my end:
[image: image.png]
The same workspace shared and viewed from the student's end:
[image: image.png]
…On Mon, 7 Dec 2020 at 13:56, Anton Kosyakov ***@***.***> wrote:
@bravoalpha79 <https://github.com/bravoalpha79> Could you share workspace
ID for which code highlighting won't work? And a snapshot if possible thank
you. You can email me anton at gitpod.io if it is confidential.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2444 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK3J3KAG5QXLBUYFGO7XM4LSTTGJLANCNFSM4UQIIWLQ>
.
|
@bravoalpha79 Could you check please the devtools network tab for any broken requests for such students? i.e.:
thank you! |
Hi Anton,
Please find below an affected workspace URL and the error/warning
screenshots:
https://a073e929-957c-4fd5-a3c2-50ce0bbed1cd.ws-eu03.gitpod.io/#/workspace/Milestone-2-Visit-Norrtalje
[image: image.png]
[image: image.png]
[image: image.png]
[image: image.png]
[image: image.png]
Kind regards,
Igor
…On Tue, 8 Dec 2020 at 06:37, Anton Kosyakov ***@***.***> wrote:
@bravoalpha79 <https://github.com/bravoalpha79> Could you check please
the devtools network tab for any broken requests for such students? i.e.:
- start a workspace
- open devtools -> network tab
- reload the page and watch out for any requests which are failing,
particularly to wasm files
thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2444 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK3J3KDA5ANU3HITOFNK7HLSTW3SDANCNFSM4UQIIWLQ>
.
|
Hi Igor, thanks but the images don't show up on GitHub. unfortunately. |
I see. How else can I send them to you?
…On Tue, 8 Dec 2020, 12:00 Sven Efftinge, ***@***.***> wrote:
Hi Igor, thanks but the images don't show up on GitHub. unfortunately.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2444 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK3J3KHY7MTSC4ILHFATJFLSTYBNNANCNFSM4UQIIWLQ>
.
|
Go to this page and drag & drop the image into the text area would work. |
Done! :)
…On Tue, 8 Dec 2020 at 12:46, Sven Efftinge ***@***.***> wrote:
Go to this page <#2444> and
drag & drop the image into the text area would work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2444 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK3J3KCJ3ZN6CXQJT2LK4ZDSTYGZZANCNFSM4UQIIWLQ>
.
|
the fix is already almost there: #2457 😉 |
We merged the tentative fix and will deploy it at the end of this week. In the meantime it would be helpful if you can verify it by using this env: http://ak-onigasm-from-blobserve.staging.gitpod-dev.com/workspaces/ @bravoalpha79 Could you ask students experiencing issues to try it there? If it fails it would be good if they can capture details (request/response headers) of failed requests from devtools network, see: https://developers.google.com/web/tools/chrome-devtools/network#details |
I went to the staging workspaces to test, but have faced two issues:
1. The Emmet seems to be available, however in CSS, most of the shortcuts
are not available (see example below for margin- and font-).
2. I'm only able to do minimal testing, as the staging environment doesn't
seem to allow me to access any of my workspaces with my settings.
|
Oh, it makes sense, in upstream it was changed how html/css are consumed: eclipse-theia/theia#7972 we should add VS Code extensions now explicitly. But I was concerned with syntax highlighting in general, as far as I understood for some students it did not work at all. Does it work with the staging env? |
PR to add missing language smartness for html/css: #2483 |
@akosyakov However I never experienced any issues with the highlighting in any of my workspaces, so I can't verify that anything has changed in that regard. |
fixes were deployed, please open new issues if something still does not work |
Fix not working. CSS Emmet now apparently works, but HTML Emmet is completely absent. Two examples of impacted workspaces: |
I am now unable to properly open any workspace. When I do and add some code and attempt to save it, the workspace disconnects. |
This should have been fixed by now. There has been a couple of other issue reported here as well. Please open new issues for anything that is still prevailing. |
Describe the bug
Since the outage on Friday 04/12/2020, multiple students have reported various issues on their workspaces:
Some issues seem to be workspace-related (the student that couldn't open his workspace was able to create a new one from the repo and that one worked), but some seem to be user-wide (code highlighting for the student worked on neither his workspace nor on mine shared, even though it worked normally at my end).
For the Emmet shortcuts, it seems that manual installing of the CSS Language Features and HTML Language Features extensions helped restore the functionality.
Steps to reproduce
Workspace that wouldn't open at all: https://c4812cfa-7975-45bf-9b06-62367ca91af0.ws-eu03.gitpod.io/#/workspace/V_Getable
Expected behavior
Workspaces should open without errors.
Code highlighting should work.
Emmet support should work.
The text was updated successfully, but these errors were encountered: