Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect maintainer_can_modify settings on PRs #413

Closed
akosyakov opened this issue Mar 25, 2019 · 4 comments
Closed

respect maintainer_can_modify settings on PRs #413

akosyakov opened this issue Mar 25, 2019 · 4 comments
Assignees
Labels
git provider: github meta: stale This issue/PR is stale and will be closed soon

Comments

@akosyakov
Copy link
Member

akosyakov commented Mar 25, 2019

I can push as a collaborator to PR:
Screenshot 2019-03-25 at 16 11 14

Gitpod does not acknowledge it:
Screen Shot 2019-03-25 at 16 12 42

I still can push from a terminal though and via Git UI.

@AlexTugarev AlexTugarev self-assigned this Mar 25, 2019
@akosyakov akosyakov changed the title respect collaborator settings on forks and on PRs from forks respect collaborator settings on PRs from forks Mar 25, 2019
@AlexTugarev AlexTugarev changed the title respect collaborator settings on PRs from forks respect maintainer_can_modify settings on PRs Mar 26, 2019
@AlexTugarev
Copy link
Member

I ran some tests on the GH API, and the only hint to determine this is checking the result of GET /repos/:owner/:repo/pulls/:number for maintainer_can_modify: boolean.

We need to improve the validation of permissions in case of a PR context (origin != upstream):

  • accept if maintainer_can_modify is true
  • notify otherwise

@akosyakov
Copy link
Member Author

I again stumbled over it in eclipse-theia/theia#7610

git push -f is good:
Screenshot 2020-04-20 at 09 05 18

But UI tells me oppositive:
Screenshot 2020-04-20 at 09 03 59
Screenshot 2020-04-20 at 09 04 01

@AlexTugarev
Copy link
Member

Revision of the git credential helper to support this is in progress. The happy path was working, but it needs to be tested and fine tuned. One unknown thing remaining ist, that git tends to cache results, which shouldn't be as it would lead to false results whenever you adjust and retry.

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Oct 4, 2020
@stale stale bot closed this as completed Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
git provider: github meta: stale This issue/PR is stale and will be closed soon
Projects
None yet
Development

No branches or pull requests

2 participants