Fix syntax highlighting by bumping onigasm

[llebout]

What it does

onigasm version requirement was tightened at cd3a35a to fix syntax highlighting but that did not work for me with Rust code. I assume the bug is now fixed upstream, onigasm latest version of 2.x series being 2.2.4.

How to test

Copy this folder: https://github.com/microsoft/vscode/tree/master/extensions/rust into Theia's tree plugins folder

Run Theia e.g. yarn start:browser

Open: http://localhost:3000

Observe syntax highlighting of a Rust project, e.g. clone: https://github.com/BurntSushi/ripgrep

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[llebout]

CI says:

ERR: The git repository state changed after the build, this should not happen.
HEAD detached at FETCH_HEAD
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)
	modified:   yarn.lock
no changes added to commit (use "git add" and/or "git commit -a")
HINT: Did you update and commit your 'yarn.lock' ?

I think this is normal that it happens?

[benoitf]

you need to add yarn.lock changes in your pull request

[llebout]

@benoitf unfortunately I can't do this because yarn doesnt support generating the lock file without installing. I am on a machine with an IBM POWER CPU and while this change fixes the issue on a git tree of mine (where I remove the electron dependency that doesnt exist for IBM POWER), Theia's tree wont work as-is on my machine.

You have permission to commit to my branch as I allowed it, so feel free to.

[akosyakov]

@Leo-LB I will do it.

fyi you could use Gitpod to correct commits: https://gitpod.io#https://github.com/eclipse-theia/theia/pull/7610

[akosyakov]

I've verified:

• no regressions with php against tokenization breaks sometimes with 2.2.2 zikaari/onigasm#17 (comment)
• rust highlighting is proper against How to test section
• [email protected] has MIT license, there are no other dependency changes

[akosyakov]

merging, build failure is not related to the PR, i will do another PR to fix CI

[llebout]

Thanks a lot @akosyakov! And right, will think about Gitpod next time! Though I'm not a fan of giving my Github credentials to it. Though I could probably generate the lock file there and transfer it locally.

[akosyakov]

Though I'm not a fan of giving my Github credentials to it.

Gitpod does not take your credentials, but only GH token you control what such token can do. Similar to all other tools like Travis, Circle CI and so on. By default it only requires access to email for login. Obviously to push you will be asked to upgrade GH token to write access for public repos.