Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code]: Generate stable images for 1.68 #10567

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Conversation

andreafalzetti
Copy link
Contributor

@andreafalzetti andreafalzetti commented Jun 9, 2022

Description

Update code to 1.68.0

How to test

  • Switch to VS Code Insiders in settings.
  • Start a workspace.
  • Test following:
    • terminals are preserved and resized properly between window reloads
    • WebViews are working ❌ Not working in Firefox [1]
    • extension host process: check language smartness and debugging
    • extension management (installing/uninstalling)
    • install the VIM extension to test web extensions
    • that user data is synced across workspaces as well as on workspace restarts, especially for extensions
      • extensions from .gitpod.yml are not installed as sync
      • extensions installed as sync are actually synced to all new workspaces
    • settings should not contain any mentions of MS telemetry
    • WebSockets and workers are properly proxied
      • diff editor should be operatable
      • trigger reconnection with window.WebSocket.disconnectWorkspace(), check that old WebSockets are closed and new opened of the same amount
    • workspace specific commands should work, i.e. F1 → type Gitpod prefix
    • that a PR view is preloaded on the PR URL
    • test gp open and gp preview
    • test open in VS Code Desktop, check gp open and gp preview in task/user terminals
    • telemetry data is collected in Segment

Release Notes

NONE

/werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe

@andreafalzetti
Copy link
Contributor Author

andreafalzetti commented Jun 9, 2022

@jeanp413 I am runninng a sample web server with npx -y live-server . and running gp preview <PORT> throws this error in console:

ERR write after end: Error: write after end
	at new NodeError (node:internal/errors:371:5)
	at ServerResponse.end (node:_http_outgoing:846:15)
	at _ (/ide/out/vs/workbench/api/node/extensionHostProcess.js:102:26240)
	at IncomingMessage.<anonymous> (/ide/out/vs/workbench/api/node/extensionHostProcess.js:102:26688)
	at IncomingMessage.emit (node:events:402:35)
	at endReadableNT (node:internal/streams/readable:1343:12)
	at processTicksAndRejections (node:internal/process/task_queues:83:21) [log.ts:313:11](https://blobserve.ws.afalz-gene500f72d2b9.preview.gitpod-dev.com/eu.gcr.io/gitpod-core-dev/build/ide/code:commit-9c6caab7bf86403da9250db7a13b9b7873cd6d98@sha256:b15dee6d5a2687de64a703ca03494026f46ba6ffd04a49f9d566e9b1d1f54616/__files__/out/vs/workbench/out-vscode-web/vs/workbench/file:/gp-code/src/vs/platform/log/common/log.ts)

And the Web View is blank 🤔

Any idea?

@jeanp413
Copy link
Member

jeanp413 commented Jun 9, 2022

Ah I've seen this before, just skip it for now, we'll need to take a look later, after the release create an issue 🙏

@andreafalzetti andreafalzetti mentioned this pull request Jun 9, 2022
16 tasks
@andreafalzetti
Copy link
Contributor Author

andreafalzetti commented Jun 9, 2022

Ah I've seen this before, just skip it for now, we'll need to take a look later, after the release create an issue 🙏

Even extensions preview in WebViews cannot be visualized, e.g:

Screenshot 2022-06-09 at 16 18 19

@jeanp413 do you mean that we release 1.68 even if it's broken? 🤔

@jeanp413
Copy link
Member

jeanp413 commented Jun 9, 2022

No, I meant gp preview only in vscode desktop it should work on web

@jeanp413
Copy link
Member

jeanp413 commented Jun 9, 2022

just tested this it works on chrome but not in firefox 🤔

@andreafalzetti
Copy link
Contributor Author

ah, I was on Firefox indeed (it's my main browser) - I didn't think about Chrome. Maybe we should add "Test X on browser X, Y, Z" in this PR template above.

@andreafalzetti
Copy link
Contributor Author

andreafalzetti commented Jun 9, 2022

btw, it's also broken in github.dev cc @jeanp413

Screenshot 2022-06-09 at 16 40 11

@andreafalzetti
Copy link
Contributor Author

andreafalzetti commented Jun 9, 2022

I've created an issue upstream: microsoft/vscode#151648

@andreafalzetti
Copy link
Contributor Author

andreafalzetti commented Jun 9, 2022

Regarding the following:

extensions from .gitpod.yml are not installed as sync

How can I verify is the extension was installed "as sync"?

cc @jeanp413

@jeanp413
Copy link
Member

jeanp413 commented Jun 9, 2022

How can I verify is the extension was installed "as sync"?

Go to extensions view and click on the extension it should ignored during sync
image

@andreafalzetti
Copy link
Contributor Author

telemetry data is collected in Segment

@jeanp413 I don't have an account on Segment, could you invite me or check on my behalf for now?

@andreafalzetti
Copy link
Contributor Author

test open in VS Code Desktop, check gp open and gp preview in task/user terminals

In VS Code Desktop, gp preview works, however previews are broken (1.68.0)

@andreafalzetti
Copy link
Contributor Author

that a PR view is preloaded on the PR URL

@jeanp413 could you clarify what this means?

@andreafalzetti andreafalzetti marked this pull request as ready for review June 9, 2022 23:59
@jeanp413
Copy link
Member

that a PR view is preloaded on the PR URL

@jeanp413 could you clarify what this means?

That this view is loaded with the PR info, you need to enable all permisions in dashboard/preferences/integrations
image

@jeanp413
Copy link
Member

jeanp413 commented Jun 10, 2022

/werft run

👍 started the job as gitpod-build-afalz-generate-code-stable-1.68.2
(with .werft/ from main)

@jeanp413 jeanp413 self-requested a review June 10, 2022 03:30
@roboquat roboquat merged commit 15cce5f into main Jun 10, 2022
@roboquat roboquat deleted the afalz/generate-code-stable-1.68 branch June 10, 2022 03:31
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: code (browser) release-note-none size/XS team: IDE
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants