-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code]: Generate stable images for 1.68 #10567
Conversation
@jeanp413 I am runninng a sample web server with ERR write after end: Error: write after end
at new NodeError (node:internal/errors:371:5)
at ServerResponse.end (node:_http_outgoing:846:15)
at _ (/ide/out/vs/workbench/api/node/extensionHostProcess.js:102:26240)
at IncomingMessage.<anonymous> (/ide/out/vs/workbench/api/node/extensionHostProcess.js:102:26688)
at IncomingMessage.emit (node:events:402:35)
at endReadableNT (node:internal/streams/readable:1343:12)
at processTicksAndRejections (node:internal/process/task_queues:83:21) [log.ts:313:11](https://blobserve.ws.afalz-gene500f72d2b9.preview.gitpod-dev.com/eu.gcr.io/gitpod-core-dev/build/ide/code:commit-9c6caab7bf86403da9250db7a13b9b7873cd6d98@sha256:b15dee6d5a2687de64a703ca03494026f46ba6ffd04a49f9d566e9b1d1f54616/__files__/out/vs/workbench/out-vscode-web/vs/workbench/file:/gp-code/src/vs/platform/log/common/log.ts) And the Web View is blank 🤔 Any idea? |
Ah I've seen this before, just skip it for now, we'll need to take a look later, after the release create an issue 🙏 |
Even extensions preview in WebViews cannot be visualized, e.g: @jeanp413 do you mean that we release 1.68 even if it's broken? 🤔 |
No, I meant |
just tested this it works on chrome but not in firefox 🤔 |
ah, I was on Firefox indeed (it's my main browser) - I didn't think about Chrome. Maybe we should add "Test X on browser X, Y, Z" in this PR template above. |
btw, it's also broken in github.dev cc @jeanp413 |
I've created an issue upstream: microsoft/vscode#151648 |
Regarding the following:
How can I verify is the extension was installed "as sync"? cc @jeanp413 |
In VS Code Desktop, |
@jeanp413 could you clarify what this means? |
That this view is loaded with the PR info, you need to enable all permisions in dashboard/preferences/integrations |
/werft run 👍 started the job as gitpod-build-afalz-generate-code-stable-1.68.2 |
Description
Update code to
1.68.0
How to test
.gitpod.yml
are not installed as syncwindow.WebSocket.disconnectWorkspace()
, check that old WebSockets are closed and new opened of the same amountgp open
andgp preview
gp open
andgp preview
in task/user terminalsRelease Notes
/werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe