Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Don't show User Notifications and Feedback on Dedicated #20583

Merged
merged 5 commits into from
Feb 7, 2025

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Feb 6, 2025

Description

This PR:

  • disables the "Notifications" tab in user settings for Dedicated installations, because there we don't send any emails to our users
  • gets rid of the Feedback button in the top navbar for dedicated-emulated preview environments

How to test

  1. Go to the preview env: (it has dedicated emulation on) https://ft-bring-p79b5247b4c.preview.gitpod-dev.com/user/account
  2. VIsit the user settings and confirm there's no "Notifications" tab
  3. Look at the top navbar and confirm there's no Feedback

/hold

Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
…-closer-to-prod

Tool: gitpod/catfood.gitpod.cloud
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested and works! ✔️

@filiptronicek filiptronicek self-assigned this Feb 7, 2025
@roboquat roboquat merged commit fb89d41 into main Feb 7, 2025
20 checks passed
@roboquat roboquat deleted the ft/bring-preview-envs-closer-to-prod branch February 7, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants