Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crashes on PR comment #450

Closed
tautf opened this issue Oct 8, 2017 · 8 comments
Closed

App crashes on PR comment #450

tautf opened this issue Oct 8, 2017 · 8 comments

Comments

@tautf
Copy link
Contributor

tautf commented Oct 8, 2017

Hey,

I tried to comment at #445

I wanted to write the following:
Hey, i can review this, my native language is German @lex11 @houssaindjirdeh

Sorry I don’t know you exact names atm😂

But when I submitted it the app crashed.

When i only added @lex11 i was able to submit the comment.

@andrewda andrewda added the crash label Oct 8, 2017
@machour
Copy link
Member

machour commented Oct 9, 2017

@FlorianTaut was that on android or ios?

@tautf
Copy link
Contributor Author

tautf commented Oct 9, 2017

@machour it was iOS 11.0.2 on a real device. I only had it once yet.

I think we’re not able to find out what caused the crash when it’s not happening again

@machour machour added the ios label Oct 9, 2017
@andrewda andrewda added this to the Release 1.4.0 milestone Oct 17, 2017
@tautf
Copy link
Contributor Author

tautf commented Oct 18, 2017

Update on this, i have crashes at nearly every issue & pr comment.
OS: iOS 11.0.2 iPhone 7
GitPoint: of course latest 😄

@andrewda
Copy link
Member

Me too @tautf

@machour
Copy link
Member

machour commented Oct 18, 2017

Hopefully this will be fixed in 1.3.1 🤞
I suspect #429 which was also affecting iOS in some cases

@vidhill
Copy link

vidhill commented Oct 27, 2017

Me too, try to leave a comment on an issue, app crashes, iOS real device

@housseindjirdeh housseindjirdeh removed this from the Release 1.4.0 milestone Nov 12, 2017
@machour
Copy link
Member

machour commented Dec 6, 2017

I think that the error reported by @tautf should have been fixed in #448, which will be in 1.4.0.

@vidhill's problem is related to #201.

@machour machour added the has pr label Dec 6, 2017
@machour
Copy link
Member

machour commented Dec 6, 2017

Closing this issue as the PR for it have been merged.

@machour machour closed this as completed Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants