feat(translation): add German translations #445
Conversation
|
@housseindjirdeh @andrewda Please review. |
| { | ||
| code: 'de', | ||
| emojiCode: ':flag-de:', | ||
| name: 'Deutsche', |
There was a problem hiding this comment.
as i was shown this result here
Should i change it to Deutsch?
There was a problem hiding this comment.
Yes, because we use the adjective.
Deutsch - adjective
Deutsche - noun
src/locale/languages/de.js
Outdated
| auth: { | ||
| login: { | ||
| connectingToGitHub: 'Verbindung zu GitHub herstellen ...', | ||
| preparingGitPoint: 'GitPoint vorbereiten ...', |
There was a problem hiding this comment.
No, its not necessary. I'll change it.
src/locale/languages/de.js
Outdated
| published: 'veröffentlicht', | ||
| publicized: 'publiziert', | ||
| privatized: 'privatisiert', | ||
| starred: 'Stern', |
There was a problem hiding this comment.
Is this exactly true? starred a verb, but Stern a noun.
There was a problem hiding this comment.
Yaa, i'll change it to starred
|
@Rishabh04-02 German is your native language? |
|
@lex111 Please review. |
src/locale/languages/de.js
Outdated
| published: 'veröffentlicht', | ||
| publicized: 'publiziert', | ||
| privatized: 'privatisiert', | ||
| starred: 'Starred', |
There was a problem hiding this comment.
Must start with a small letter. And why starred, in German is how will it be? bemerken?
There was a problem hiding this comment.
I'm not sure about it, here it is showing that bemerken translates to - to notice in english here
So, should i only convert it to lowercase?
No, Its not. |
|
@Rishabh04-02 thanks for the help, although it was not written in the issue #439, but it is desirable, of course, that the translation was from the native speaker, since then it will be more accurate. Because the translation with Google Translate sometimes gives unexpected results. @housseindjirdeh what should we do in this case? Waiting for the native translator to check this translation? |
|
@lex111 Yaa, I can understand that It's important to validate the content from native speaker 👍. |
Issue - Translation for other languages #439
andrewda
changed the title
|
I can review, german is my native language @lex111 |
|
@FlorianTaut ok, that was cool! |
|
@Rishabh04-02 did you translate this with google translator? Because I just read some lines and they make no sense. |
|
@FlorianTaut
Yes, I've used google translator for most of the translations and the English to German dictionary for the others. |
|
The problem is, this translation is nearly unuseful. 90% are wrong translated and make no sense. How should we go on with this? There is so much to do that in my opinion it would be more useful to delete this pr an make a complete new one. I already have it translated but I’m currently not possible to test it in the emulator so I didn’t sent a pr yet. |
|
Well done, if this given translation is almost completely incorrect, and there is a good translation, I agree, it makes no sense to edit the current PR and it should be closed then. @FlorianTaut you have previously sent a PR with a German translation and closed because it was not possible to check? Well, if the translation was finished, then you did not need to close the PR, because In any case, this is a fixable problem, after all, someone else has checked that the application is working with a new translation. In general, if there is a translation, send PR, the main thing is to have the correct translation. If something does not work, then you can write to Gitter, we will try to help you. |
|
@FlorianTaut Thanks for reviewing, I've closed the PR now. |
|
@Rishabh04-02 thanks anyway for wanting to help. If you know React Native, and you have a desire to help, then you can take another issue, we will be glad and will try to help if there are difficulties. |
|
Thank you for this @Rishabh04-02 and apologies on my part, I should have been more clear in the contributing docs that we're looking for language speakers to translate our content in depth. I pushed a commit to make things more clear. Really appreciate the time you took to translate each string and please don't hesitate to snag any issue you think you'd like to help with as @lex111 mentioned. |
|
@housseindjirdeh @lex111 Thanks for the steps you took to avoid such problems in future. I'll be looking forward to contribute to this awesome project 😄 . |
|
Thank you so much mate, can't tell you how much we appreciate that 🎉 🎉 🎉 |
Issue - Translation for other languages #439