Fix FeatureEffect handling of empty levels #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing test missed this bug because it was only testing the special case where the last level is empty.
|
Thanks for finding and fixing this non-obvious issue! Good find. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
FeatureEffectdoes not handle empty levels correctly. The existing test missed this bug because it was only testing the special case where the last level is empty.Implementation
Fixed by adding the missing
droplevels(x). It may be cleaner to add a linex <- droplevels(x)immediately after x is created, and then remove all thedroplevels(x)statements elsewhere.The test was updated to catch the bug by simply reversing the order of the levels.