Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex containers' justify-content property options and keyboard shortcuts #191

Closed
SteffenLehmann opened this issue Sep 20, 2023 · 6 comments
Assignees

Comments

@SteffenLehmann
Copy link

Hi Gareth J. Barnard,

Thank you for maintaining the grid format plugin; it is very useful. I’m working at Aalborg University in Denmark, and we are currently updating Moodle from 3.11 to 4.1.5. We have used the grid format in 3.11, but the flex containers' justify-content property has changed from center to between, which we would like to change.

However, changing the justify-content property does not seem to be the solution, as people have different preferences. Therefore, we would like to add a setting where you could select from the different justify-content property options, such as: start, center, space-between, space-around, and space-evenly.

Moreover, some keyboard shortcuts have also disappeared: arrow navigation between pop-up topics and the escape key (esc) does not open the highlighted topic when no topics are in the pop-up state.

How much would each improvement and all improvements cost?

For further correspondence, please contact me here: [email protected]

Best,
Steffen L.

@gjb2048
Copy link
Collaborator

gjb2048 commented Sep 20, 2023

Dear @SteffenLehmann,

I've just sent you an eMail from my dot co dot uk eMail address, please let me know if you don't get it.

Kind regards,

Gareth

gjb2048 added a commit that referenced this issue Sep 20, 2023
@gjb2048
Copy link
Collaborator

gjb2048 commented Sep 20, 2023

@SteffenLehmann I've improved the keyboard control in ee34c8c - as I feel that being an accessibility issue, then I should do this not as an enhancement but as a bug and that I'm morally responsible to do so. The grid sections can now be tabbed to (when popup) forward (Tab) and backwards (Shift Tab), and opened with Enter. The popup remains the same and can be closed, next / previous with the buttons - again tabbed to. The original arrow key and Esc control was always a workaround as not standard accessible control.

@SteffenLehmann
Copy link
Author

Hi @gjb2048,

Thank you for sending an offer, I will discuss the improvement cost with my project lead and get back to you.

I'm glad that you have added keyboard navigation back to the plugin.

You will hear from us through email, when we have made a decision.

Best,
SL

@gjb2048
Copy link
Collaborator

gjb2048 commented Sep 21, 2023

Related to: #188

gjb2048 added a commit that referenced this issue Sep 22, 2023
gjb2048 added a commit that referenced this issue Sep 22, 2023
gjb2048 added a commit that referenced this issue Sep 22, 2023
gjb2048 added a commit that referenced this issue Sep 22, 2023
gjb2048 added a commit that referenced this issue Sep 25, 2023
gjb2048 added a commit that referenced this issue Sep 25, 2023
@gjb2048
Copy link
Collaborator

gjb2048 commented Sep 26, 2023

@SteffenLehmann Please note a change in the URL -> #191

gjb2048 added a commit that referenced this issue Sep 28, 2023
gjb2048 added a commit that referenced this issue Sep 28, 2023
gjb2048 added a commit that referenced this issue Sep 29, 2023
gjb2048 added a commit that referenced this issue Sep 29, 2023
gjb2048 added a commit that referenced this issue Sep 30, 2023
gjb2048 added a commit that referenced this issue Sep 30, 2023
gjb2048 added a commit that referenced this issue Sep 30, 2023
gjb2048 added a commit that referenced this issue Oct 4, 2023
…. When the arrows are used the current selected section will show using an inner border to avoid conflict with accessibility, then use Esc to open the modal. Accessibility keys of Tab / Shift Tab and Enter will function to navigate with the focussed item and when a grid section is selected, the Enter key will open the modal. On the modal itself, the same keys will navigate the slider controls and the two close buttons, as well as the modules within the section. #191.
gjb2048 added a commit that referenced this issue Oct 4, 2023
…. When the arrows are used the current selected section will show using an inner border to avoid conflict with accessibility, then use Esc to open the modal. Accessibility keys of Tab / Shift Tab and Enter will function to navigate with the focussed item and when a grid section is selected, the Enter key will open the modal. On the modal itself, the same keys will navigate the slider controls and the two close buttons, as well as the modules within the section. #191.
@gjb2048 gjb2048 removed Funding required Triaged Issue read and is on backlog labels Oct 4, 2023
@gjb2048
Copy link
Collaborator

gjb2048 commented Dec 6, 2023

Completed.

@gjb2048 gjb2048 closed this as completed Dec 6, 2023
@gjb2048 gjb2048 added the Fixed label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants