-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flex containers' justify-content
property options and keyboard shortcuts
#191
Comments
Dear @SteffenLehmann, I've just sent you an eMail from my dot co dot uk eMail address, please let me know if you don't get it. Kind regards, Gareth |
@SteffenLehmann I've improved the keyboard control in ee34c8c - as I feel that being an accessibility issue, then I should do this not as an enhancement but as a bug and that I'm morally responsible to do so. The grid sections can now be tabbed to (when popup) forward (Tab) and backwards (Shift Tab), and opened with Enter. The popup remains the same and can be closed, next / previous with the buttons - again tabbed to. The original arrow key and Esc control was always a workaround as not standard accessible control. |
Hi @gjb2048, Thank you for sending an offer, I will discuss the improvement cost with my project lead and get back to you. I'm glad that you have added keyboard navigation back to the plugin. You will hear from us through email, when we have made a decision. Best, |
Related to: #188 |
@SteffenLehmann Please note a change in the URL -> #191 |
…. When the arrows are used the current selected section will show using an inner border to avoid conflict with accessibility, then use Esc to open the modal. Accessibility keys of Tab / Shift Tab and Enter will function to navigate with the focussed item and when a grid section is selected, the Enter key will open the modal. On the modal itself, the same keys will navigate the slider controls and the two close buttons, as well as the modules within the section. #191.
…. When the arrows are used the current selected section will show using an inner border to avoid conflict with accessibility, then use Esc to open the modal. Accessibility keys of Tab / Shift Tab and Enter will function to navigate with the focussed item and when a grid section is selected, the Enter key will open the modal. On the modal itself, the same keys will navigate the slider controls and the two close buttons, as well as the modules within the section. #191.
Completed. |
Hi Gareth J. Barnard,
Thank you for maintaining the grid format plugin; it is very useful. I’m working at Aalborg University in Denmark, and we are currently updating Moodle from 3.11 to 4.1.5. We have used the grid format in 3.11, but the flex containers'
justify-content
property has changed from center to between, which we would like to change.However, changing the
justify-content
property does not seem to be the solution, as people have different preferences. Therefore, we would like to add a setting where you could select from the differentjustify-content
property options, such as: start, center, space-between, space-around, and space-evenly.Moreover, some keyboard shortcuts have also disappeared: arrow navigation between pop-up topics and the escape key (esc) does not open the highlighted topic when no topics are in the pop-up state.
How much would each improvement and all improvements cost?
For further correspondence, please contact me here: [email protected]
Best,
Steffen L.
The text was updated successfully, but these errors were encountered: