Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a spec for stress testing garbage collection #80

Merged
merged 7 commits into from
Oct 8, 2024
Merged

Add a spec for stress testing garbage collection #80

merged 7 commits into from
Oct 8, 2024

Conversation

jordandcarter
Copy link
Contributor

@jordandcarter jordandcarter commented Oct 3, 2024

We ran into segmentation faults in production and eventually narrowed it down to selma. Here is a test which turns on GC.stress which reliably causes the segfault.

Issue raised here #81

@gjtorikian gjtorikian merged commit 12d97d2 into gjtorikian:main Oct 8, 2024
11 checks passed
@gjtorikian
Copy link
Owner

tl;dr for the fix: the memory for the hash sanitization config was initialized in Rust, then passed to Ruby, then used entirely in Rust. I had flagged that back and forth volleyball as an issue but it never caused an observable problem (until now).

I moved all the config setup entirely in Rust, and the test passes. 👍

Noticed some segmentation faults in production,

If Selma helps you at work, please, consider sponsoring. ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants