Add ZoneId converter

[pavanpvpk]

No description provided.

[gkopff]

Hi @pavanpvpk - sorry to take so long to get back to you, I've been travelling.

I have a couple of points of feedback:

• could we please limit the PR to the code change, and leave out the various IntelliJ file changes. If those are useful to propagate forward, I think they should go in a separate PR
• could you please match the style (brace location, indentation, whitespace etc) with the existing source code
• I don't think its warranted to add a dependency on commons-lang3 for a single method to check if a string is blank. If we require this logic (not null, not empty, not whitespace), we can add that longhand ourselves. My opinion however is that isBlank is too "wide" - I can accept that a null value convert to null, and that an empty string convert to null, but I don't think whitespace should convert successfully to anything.

[pavanpvpk]

@gkopff extremely sorry for the delay. I have made the changes and added few new test cases as well. Let me know your feedback.

[ahmedkhalf]

@gkopff Yo, any idea idea when this gonna be pushed? I have been impatiently waiting for three years.

[gkopff]

@ahmedkhalf the formatting fixes never got done, so that's why it was sitting there. I've fixed the formatting myself today - but it will be a few days to work out pushing to Maven Central. Things have changed since I last did it.

[gkopff]

@ahmedkhalf This has been released, but due to a backlog in the Maven Central indexing, it's not yet reported by the search. It should be resolvable by Maven itself though - I've bene in contact with Sonatype about it: https://issues.sonatype.org/browse/OSSRH-82669

[gkopff]

@ahmedkhalf This is all indexed now: https://search.maven.org/artifact/com.fatboyindustrial.gson-javatime-serialisers/gson-javatime-serialisers/1.1.2/jar

[ahmedkhalf]

Thank you!

But now even though the tests are passing I am getting a warning:

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.gson.internal.reflect.ReflectionHelper (file:/home/ahmedk/.m2/repository/com/google/code/gson/gson/2.9.0/gson-2.9.0.jar) to field java.time.ZoneRegion.id
WARNING: Please consider reporting this to the maintainers of com.google.gson.internal.reflect.ReflectionHelper
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

After some investigation, I decided to use reflection to get the private class in java.time that was causing issues:

builder.registerTypeAdapter(getClassByName("java.time.ZoneRegion"), new ZoneIdConverter());

not sure if this is the best way to go about this...

should I file an issue?

[gkopff]

As the warning says, that's a Gson issue. I don't think Gson will ever address it. Moshi appears to be the successor to Gson, as per: google/gson#1821