Skip to content

Commit

Permalink
fix unhandled promise and update outdated (#196)
Browse files Browse the repository at this point in the history
* fix unhandled rejection

* update outdated

* add travis
  • Loading branch information
gkushang authored Sep 2, 2019
1 parent 38653e2 commit 4a4247c
Show file tree
Hide file tree
Showing 7 changed files with 353 additions and 804 deletions.
9 changes: 8 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
language: node_js
node_js:
- 7.7.1
- 12

before_script:
- curl -o- -L https://yarnpkg.com/install.sh
- export PATH="$HOME/.yarn/bin:$PATH"

cache:
npm: false
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
### 5.0.1 (unpublished)

* Remove duplicate check condition PR#189
* Scenario timestamp and notes PR#190
* Fixed regression of 4.0.4, fixes ISSUE#160 PR#191
* Bump lodash from 4.17.11 to 4.17.13 PR#193
* Bump diff from 3.4.0 to 3.5.0 PR#194

### 5.0.0 (Apr-16-2019)

* Fix data tables not being read in - [PR#172](https://github.com/gkushang/cucumber-html-reporter/pull/172)
Expand Down
4 changes: 0 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -294,10 +294,6 @@ Attach JSON to HTML report
[changelog][10]
## Credits
Credit to the developers of [grunt-cucumberjs][1] for developing pretty HTML reporting. HTML reporting is extracted from the grunt task. Thanks to all the contributors for making HTML Reporting available to the wider audiences of [cucumber-js][2] community.
[1]: https://www.npmjs.com/package/grunt-cucumberjs "grunt-cucummberjs"
[2]: https://github.com/cucumber/cucumber-js "CucumberJs"
[3]: http://htmlpreview.github.io/?https://github.com/gkushang/cucumber-html-reporter/blob/develop/samples/html_reports/cucumber_report_hierarchy.html "Hierarchy Theme Reports"
Expand Down
6 changes: 3 additions & 3 deletions lib/reporter.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ var _ = require('lodash');
var fs = require('fs-extra');
var path = require('path');
var jsonDir = require('./jsonDir');
var opn = require('opn');
var open = require('open');
var searchFileUp = require('./searchFileUp');
var hierarchyReporter = require('./hierarchyReporter');

Expand Down Expand Up @@ -462,9 +462,9 @@ function generate(options, callback) {
}
}

function launchReport() {
async function launchReport() {
if (fs.existsSync(options.output) && (options.launchReport || options.launchReport === 'true')) {
opn(options.output);
await open(options.output);
}
}

Expand Down
Loading

0 comments on commit 4a4247c

Please sign in to comment.