-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source maps? #452
Comments
#260 |
+1! |
👍 I was actually shocked that LiveScript didn't offer these... No source maps are a deal breaker in my workspace. CoffeeScript, TypeScript, and Traceur offer Source Maps. Source maps are the only reason I'd even consider a transpiled language. |
Hope this helps someone somehow... Says coffescript in the readme but I think they just didn't update it. https://npmjs.org/package/karma-livescript-preprocessor James Wilson On Wed, Jan 29, 2014 at 12:57 PM, Ben Lesh [email protected] wrote:
|
@jamesdwilson unrelated. it was just forked from coffee which has that version |
Also, if somebody wants to take a stab at it, I believe an external library + a switch to disable it on the browser would be far easier |
This would be very useful, development is impeded somewhat by errors reported as occurring miles from the site of the problem. |
is anyone going to do this? if not, I could probably do some work on it... I'll be using the following articles as reference: it seems pretty straightforward... the only problem being the any takers? I'll be more than happy to do it. reason? I'm getting sick of doing the compile to js and look for the line to identify where in the .ls file it is, routine... :) I'm sure the time it'll take me to add it, will still be less than the time I'm spending daily searching for the errors |
If you're interested, you might also want to look at @jwalton's PRs on coffee (although we might want to use a library like mozilla/source-map, but this solution has problems too (BSD advertising clause, harder for browser-side)). |
BSD advertising clause: source-map license: I'm no lawyer, but it looks to me like they are using the revised license without the advertisng clause I'll have a look at it a bit more, later when I get some spare time. It looks pretty straight-forward. and, looking at those pull requests helped - but not that much. right now with what I have, I'm just traversing the ast and building SourceNodes. got lots of debugging to do, and it's not integrated into LiveScript either. I just set all columns to 0. I wanted to set the columns correctly and do something like https://github.com/thlorenz/stack-mapper for the stack traces. later, I want to add long traces, because I'm doing a lot of setTimeout/nextTick type stuff... |
Please add support for V3 source-map. To convince folks, @kizu shared some really interesting ideas here: markedjs/marked#382. WE2013 has side-by-side preview support for LiveScript. Given the source-map, we can add features like "Go To Definition - F12" in context menu similar to those we have for CSS preprocessors. (despite the fact they all support source-maps; we haven't done that for Coffee, IcedCoffee SweetJS and TS yet as VS's JS lang service classes are |
+1 for source maps |
+1 |
1 similar comment
+1 |
+1'ing here too. I just tried Coffeescript's maps and it is pretty much the best thing ever in my browser. |
+1 |
2 similar comments
+1 |
+1 |
"+1"s are not helping, really. |
It's hard to express how "+1"s are a annoying and disrespectful, without sounding rude. |
Well with the lack of a voting system for issues, there's no other way to express community interest in a particular issue. Forking is not a solution. Regardless, I'm going to take a stab at implementing this, since it's about time LiveScript got sourcemaps... |
If there's no developer interest in a specific feature, then community interest is a bit moot. |
I believe this feature has been road mapped already. #260 |
If you have the energy to work on both, do it, no problem. I don't want to learn csr, or to have to start "from scratch" again, and I don't want to work on the current elxer because of how tangled everything is. |
I thinks thats fair to feel that way, and I hear where you're coming from. We all keep asking for this feature, but there's all this underlining work that needs to be done before that can happen. What areas would ideally be addressed first before Source Map support? I would be willing to work on various things if it meant we would eventually be able to add this. |
My two cents here: Sweet.js is another superset language of JavaScript, which makes use of an npm module called Sweet.js: https://github.com/mozilla/sweet.js. |
I don't mind the |
Isn't it about time to start on LS2 now that CSR is somewhat stable and ES6 is coming up? |
As you can see, I've just submitted a PR which adds basic source-map support. It could do with a lot more testing though (hint hint, everyone who +1ed this!) and it's only fairly rough at the moment. |
👍 Suddenly this is all happening so fast! :D |
That's why I think a fork is useful while +1s are just noise: They get things moving. |
Bitching about +1s is noise... |
@demux No. Explaining why people should contribute more, with no fear, instead of just asking for things. You've missed my whole point. |
@blvz So you think that people are afraid to contribute? If that's the case at least some of the time, then obviously they shouldn't be afraid. |
@demux I think most people are. But maybe "fear" wasn't the right word to describe it. Most people in user-land don't have the motivation to give it a go. While I agree that asking isn't a bad thing, there are better ways to do it. But hey, that's just my opinion, which I've thought it was worth sharing (while I do "bitch" about every +1s, in silence). Anyone's welcome to disagree and even gkz said he's ok with the +1s, so this discussion already did more noise than the +1s themselves. |
Forgive me if this is a repeat but I didn't find any issues about this.
Does LiveScript compiler support generating source maps?
The reason I ask is because both coffeescript and TypeScript seem to support it.
The text was updated successfully, but these errors were encountered: