-
-
Notifications
You must be signed in to change notification settings - Fork 151
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Set iframe background color on neovim's default_colors_set (#1637)
Issue #1637 reports that resizing the underlying textarea of a Firenvim iframe can result in flashes of color. This can be particularly visible when using Firenvim with a dark colorscheme on Github in dark mode. The reason for these flashes of color is that when resizing, the iframe gets resized first and the Neovim canvas gets resized second, between these two moments, the iframe's background color can become visible if the CSS colorscheme of the iframe and of the website do not match. We fix this by ensuring that the iframe's background color is set to the background color of the Neovim colorscheme. This breaks the ability of the iframe to turn transparent when unfocused (the iframe gets dimmed instead), but given that multiple users complained about this feature, it may not be such a bad change. Closes #1637.
- Loading branch information
Showing
3 changed files
with
8 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters