Fix poisoned queues #563
Merged
Fix poisoned queues #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes beta and production trying to process jobs enqueued by the other, which can make a box error indefinitely as it tries to run a job it doesn't know how to run. Along with this I'll set QUEUE_PREFIX to `production` and `beta` on the respective boxes.
BatedUrGonnaDie
approved these changes
Jul 1, 2019
Previous commit didn't work because delayed_job takes from all queues indiscriminately unless you manually specify the QUEUES env var. There is no way to do this based on prefix, but I've opened collectiveidea/delayed_job#1095. For now we'll have to keep QUEUES in sync with the jobs we have.
BatedUrGonnaDie
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes beta and production trying to process jobs enqueued by the other, which can make a box error indefinitely as it tries to run a job it doesn't know how to run.
Along with this I'll set QUEUE_PREFIX to
productionandbetaon the respective boxes.