Add "Pattern match on argument" code action #4153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomocavalieri
commented
Jan 7, 2025
Comment on lines
-1894
to
+1900
| kind: TodoKind::EmptyFunction, | ||
| location: SrcSpan { start, end }, | ||
| kind: TodoKind::EmptyFunction { | ||
| function_location: SrcSpan { start, end } | ||
| }, | ||
| location: SrcSpan { | ||
| start: left_brace_start + 1, | ||
| end: right_brace_end | ||
| }, |
There was a problem hiding this comment.
Previously when the compiler inserted an implicit todo in an empty function body it marked its position as starting at the start of the function declaration. This would mess up code actions that rely on a function's body's statement to always come inside the curly braces.
I found this out implementing the "Destructure argument" code action and changed it here so that an implicit todo now has the following span:
pub fn main() { }
// ^^ This span inside the function's body
// ^^^^^^^^^^^^^ Instead of this span outside the function's bodyIt still carries around the entire function span to produce nice error messages for incomplete code in the TodoKind::EmptyFunction variant
lpil
reviewed
Jan 7, 2025
.../snapshots/gleam_core__language_server__tests__action__destructure_argument_empty_tuple.snap
Outdated
Show resolved
Hide resolved
lpil
reviewed
Jan 7, 2025
And add documentation to the relevant function explaining this behaviour
Instead of being called `value_0` it just uses `value` which looks way better when there's just a single unlabelled field: let Wibble(value) = arg // instead of let Wibble(value_0) = arg
giacomocavalieri
force-pushed
the
fix-4139
branch
from
21de198 to
3196ea3
Compare
|
I've updated this to:
|
lpil
reviewed
Jan 8, 2025
giacomocavalieri
changed the title
previously if a type were internal the "pattern match on argument" code action would never trigger. However, one would want to do that if they're working in the same module where the type is defined
giacomocavalieri
commented
Jan 9, 2025
...m_core__language_server__tests__action__pattern_match_on_argument_works_on_fn_arguments.snap
Show resolved
Hide resolved
lpil
reviewed
Jan 9, 2025
...m_core__language_server__tests__action__pattern_match_on_argument_works_on_fn_arguments.snap
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #4139.
The tests cover loads of different cases but here's a small example of what it looks like in practice:
