Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the src importing test error message #4171

Merged
merged 1 commit into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,3 +125,7 @@
- Fixed a bug where a block expression containing a singular record update would
produce invalid erlang.
([yoshi](https://github.com/joshi-monster))

- Fixed a typo in the error message when trying to import a test module into an
application module.
([John Strunk](https://github.com/jrstrunk))
2 changes: 1 addition & 1 deletion compiler-core/src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1492,7 +1492,7 @@ Erlang's floating point type. To avoid this error float values must be in the ra
"The application module `{src_module}` \
is importing the test module `{test_module}`.

Test modules are not included in production builds so test \
Test modules are not included in production builds so application \
modules cannot import them. Perhaps move the `{test_module}` \
module to the src directory.",
);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
---
source: test-package-compiler/src/generated_tests.rs
assertion_line: 273
expression: "./cases/src_importing_test"
---
error: App importing test module
Expand All @@ -11,6 +10,5 @@ error: App importing test module

The application module `one` is importing the test module `two`.

Test modules are not included in production builds so test modules cannot
import them. Perhaps move the `two` module to the src directory.

Test modules are not included in production builds so application modules
cannot import them. Perhaps move the `two` module to the src directory.
Loading