Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing types when resolving from exports field in package.json #561

Merged

Conversation

Schleuse
Copy link
Contributor

ShuffleJs is missing Typescript types when using modern node export fields. This happens for example when using moduleResolution: bunlder in tsconfig.json

image

This PR adds types to the exports declaration in package.json.

For more information about this, see here:

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing

Copy link
Owner

@glen-cheney glen-cheney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@glen-cheney glen-cheney merged commit 1d89c65 into glen-cheney:main Feb 22, 2024
@glen-cheney
Copy link
Owner

glen-cheney commented Feb 22, 2024

Published as 6.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants