Add Session.RawCommand() #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do sort of wish it was possible to make shlex optional if it's not needed, but this at least removes the call. |
progrium
approved these changes
Jun 19, 2019
|
Thanks for doing that, I sort of just used my own branch and forgot, cheers :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My main use case for this would be SSH_ORIGINAL_COMMAND. Many SSH servers set this when running commands on the server itself, and it's very annoying (and error prone) to set without having the RawCommand. I also opted for only calling shlex when needed, as it's an operation which doesn't need to be done in all cases.
This would replace #93 (Proper attribution for @andrewchambers is still there) as the original pull request is missing the line to actually set rawCmd.