[FEATURE] Ember/Glimmer interop #58
Conversation
pzuraq
force-pushed
the
ember/glimmer-interop
branch
3 times, most recently
from
084ef34 to
937446b
Compare
packages/@glimmerx/babel-plugin-component-templates/test/fixtures/ember/output.js
Outdated
Show resolved
Hide resolved
| const precompileTemplate = (templateString, templateTokens, options) => { | ||
| let compiled = templateCompiler.precompile(templateString, options); | ||
|
|
||
| return `Ember.HTMLBars.template(${compiled})`; | ||
| }; |
There was a problem hiding this comment.
Can we leverage ember-cli-htmlbars here? We know the host will already have it...
There was a problem hiding this comment.
How do you mean exactly? Instead of loading the template compiler here?
There was a problem hiding this comment.
Yeah, the template compiler loading is "tricky". The current implementation will not support the app having AST tranforms (e.g. for {{t/{{t-def, et al) because it doesn't load plugins.
This is fine for now, but I'd like to add an API to ember-cli-htmlbars that we can just use directly.
pzuraq
force-pushed
the
ember/glimmer-interop
branch
2 times, most recently
from
51b6d85 to
6305589
Compare
| @@ -1 +1,3 @@ | |||
| export { service } from './src/decorator'; | |||
|
|
|||
| export default class Service {} | |||
There was a problem hiding this comment.
Is the plan to add more things here? or is this class needed to match the default export from @ember/service?
There was a problem hiding this comment.
The class is just needed to match the default export for the time being. We can consider adding more in the future, but for now an empty class is probably fine, don't want to commit to more API space before we think it through.
pzuraq
force-pushed
the
ember/glimmer-interop
branch
from
6305589 to
fddad85
Compare
This PR adds basic Ember/Glimmer interop for GlimmerX. This allows users to write libraries and components using GlimmerX in both frameworks. It works by providing alternative implementations for each package, one for standard Glimmer/TS/Webpack builds, one for Ember builds. Eventually the goal is to unify these as much as possible, but for now this unlocks experimentation and cross-compatiblity. Changes include: - Babel plugin has been updated to include an `ember` option and the ability to pass a custom `precompileTemplate` function, for the Ember side to use. - Most Glimmer imports have been replaced with no-ops (like `on` and `fn`). Ember templates and components still rely on resolution, so these "just work" anyways. - User "imports" will continue to work in Ember, as long as the files are exported in the correct place, since Ember still relies on resolution and doesn't have true imports. - Services work, and an empty base `Service` class has been added so that users can import and extend it, like they would in Ember. In the Ember side, services need to be exported from the `/services` folder like normal. In the Glimmer side, they need to be instantiated and passed to `renderComponent`. The PR also adds smoke tests for the new functionality, to make sure we don't accidentally break it.
pzuraq
force-pushed
the
ember/glimmer-interop
branch
from
fddad85 to
62e46f0
Compare
This PR adds basic Ember/Glimmer interop for GlimmerX. This allows users
to write libraries and components using GlimmerX in both frameworks. It
works by providing alternative implementations for each package, one for
standard Glimmer/TS/Webpack builds, one for Ember builds. Eventually the
goal is to unify these as much as possible, but for now this unlocks
experimentation and cross-compatiblity.
Changes include:
emberoption and theability to pass a custom
precompileTemplatefunction, for the Emberside to use.
onandfn). Ember templates and components still rely on resolution, sothese "just work" anyways.
are exported in the correct place, since Ember still relies on
resolution and doesn't have true imports.
Serviceclass has been added sothat users can import and extend it, like they would in Ember. In the
Ember side, services need to be exported from the
/servicesfolderlike normal. In the Glimmer side, they need to be instantiated and
passed to
renderComponent.The PR also adds smoke tests for the new functionality, to make sure we
don't accidentally break it.