Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest glimmerjs and glimmer-vm #93

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Update to latest glimmerjs and glimmer-vm #93

merged 2 commits into from
Jan 20, 2021

Conversation

chiragpat
Copy link
Collaborator

@chiragpat chiragpat commented Jan 20, 2021 •
edited
Loading

How

  • Update babel plugin snapshots with the new output from strict mode compilation
  • Update tests to have actual component classes
  • Update helper manager with the new api from the vm
  • Add support for simple helper and modifier functions which was removed from glimmerjs

chadhietala
chadhietala reviewed Jan 20, 2021
View reviewed changes
Copy link
Member

@chadhietala chadhietala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks fine to me. Just a clarifying question.

packages/@glimmerx/babel-plugin-component-templates/test/fixtures/ember/code.js
@@ -4,5 +4,5 @@ const unknownValue = null;
const MaybeComponent = null;
const maybeModifier = null;
class MyComponent extends Component {
static template = hbs`<h1 {{maybeModifier}}>Hello world {{unknownValue}}<MySubComponent><MaybeComponent /></MySubComponent></h1>`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did MySubComponent not exist and now it throws?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup thats exactly what happens since we are compiling in strict mode.

@chiragpat chiragpat merged commit 1fab40b into master Jan 20, 2021
This was referenced Mar 15, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadhietala chadhietala chadhietala left review comments

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chiragpat @chadhietala