-
Notifications
You must be signed in to change notification settings - Fork 192
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[REFACTOR] Extract environment variables into global context
There are a number of environment variables that are currently threaded through glimmer that are: 1. Only environment variables for compatibility reasons (e.g. legacy Ember compat) 2. Never expected to change over the lifetime of an append 3. Never expected to differ between different apps or render trees in the same context. This PR consolidates these into a single global context, exported from `@glimmer/global-context`, which is set once by the embedding environment before rendering. It also upstreams the logic for `protocolForUrl`, which was not specific to Ember, and simplifies the `attributeFor` logic to be as minimal as possible an interface for Ember.
- Loading branch information
Chris Garrett
committed
Aug 21, 2020
1 parent
280f581
commit 79ff403
Showing
38 changed files
with
636 additions
and
537 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.